Bug 178132

Summary: Bump default cache storage quota to 20MB
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebCore Misc.Assignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, commit-queue, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

youenn fablet
Reported 2017-10-10 08:49:15 PDT
Bump default cache storage quota to 20MB
Attachments
Patch (13.72 KB, patch)
2017-10-10 10:08 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (13.73 KB, patch)
2017-10-10 10:36 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (28.07 KB, patch)
2017-10-10 16:57 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (28.71 KB, patch)
2017-10-10 17:01 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2017-10-10 10:08:22 PDT
Created attachment 323313 [details] Patch
youenn fablet
Comment 2 2017-10-10 10:36:13 PDT
Created attachment 323317 [details] Patch
Alex Christensen
Comment 3 2017-10-10 13:02:17 PDT
Comment on attachment 323317 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=323317&action=review > Source/WebKit/NetworkProcess/NetworkProcess.cpp:774 > +void NetworkProcess::setCacheStoragePerOriginQuota(uint64_t quota) This shouldn't be here. > Source/WebKit/NetworkProcess/NetworkProcess.h:149 > uint64_t cacheStoragePerOriginQuota() const; > + void setCacheStoragePerOriginQuota(uint64_t); These should both be removed and replaced by values on WebsiteDataStore. > Source/WebKit/UIProcess/API/APIProcessPoolConfiguration.h:157 > + uint64_t m_cacheStoragePerOriginQuota { WebKit::WebsiteDataStore::defaultCacheStoragePerOriginQuota }; This should be completely removed. > Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.h:187 > + unsigned m_cacheStoragePerOriginQuota { defaultCacheStoragePerOriginQuota }; uint64_t
youenn fablet
Comment 4 2017-10-10 16:57:00 PDT
Created attachment 323361 [details] Patch
youenn fablet
Comment 5 2017-10-10 17:01:58 PDT
Created attachment 323363 [details] Patch
WebKit Commit Bot
Comment 6 2017-10-11 13:41:03 PDT
Comment on attachment 323363 [details] Patch Clearing flags on attachment: 323363 Committed r223207: <https://trac.webkit.org/changeset/223207>
WebKit Commit Bot
Comment 7 2017-10-11 13:41:05 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2017-10-11 13:42:19 PDT
<rdar://problem/34940657>
Note You need to log in before you can comment on or make changes to this bug.