Bug 178132

Summary: Bump default cache storage quota to 20MB
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebCore Misc.Assignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, commit-queue, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Description youenn fablet 2017-10-10 08:49:15 PDT
Bump default cache storage quota to 20MB
Comment 1 youenn fablet 2017-10-10 10:08:22 PDT
Created attachment 323313 [details]
Patch
Comment 2 youenn fablet 2017-10-10 10:36:13 PDT
Created attachment 323317 [details]
Patch
Comment 3 Alex Christensen 2017-10-10 13:02:17 PDT
Comment on attachment 323317 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=323317&action=review

> Source/WebKit/NetworkProcess/NetworkProcess.cpp:774
> +void NetworkProcess::setCacheStoragePerOriginQuota(uint64_t quota)

This shouldn't be here.

> Source/WebKit/NetworkProcess/NetworkProcess.h:149
>      uint64_t cacheStoragePerOriginQuota() const;
> +    void setCacheStoragePerOriginQuota(uint64_t);

These should both be removed and replaced by values on WebsiteDataStore.

> Source/WebKit/UIProcess/API/APIProcessPoolConfiguration.h:157
> +    uint64_t m_cacheStoragePerOriginQuota { WebKit::WebsiteDataStore::defaultCacheStoragePerOriginQuota };

This should be completely removed.

> Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.h:187
> +    unsigned m_cacheStoragePerOriginQuota { defaultCacheStoragePerOriginQuota };

uint64_t
Comment 4 youenn fablet 2017-10-10 16:57:00 PDT
Created attachment 323361 [details]
Patch
Comment 5 youenn fablet 2017-10-10 17:01:58 PDT
Created attachment 323363 [details]
Patch
Comment 6 WebKit Commit Bot 2017-10-11 13:41:03 PDT
Comment on attachment 323363 [details]
Patch

Clearing flags on attachment: 323363

Committed r223207: <https://trac.webkit.org/changeset/223207>
Comment 7 WebKit Commit Bot 2017-10-11 13:41:05 PDT
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2017-10-11 13:42:19 PDT
<rdar://problem/34940657>