Bug 178114

Summary: Calling fileSystemDirectoryEntry.getDirectory() with empty path should not fail
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebCore Misc.Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, darin, jsbell, rniwa, sam, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar, WebExposed
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
URL: http://w3c-test.org/entries-api/filesystemdirectoryentry-getDirectory-manual.html
Attachments:
Description Flags
Patch none

Description Chris Dumez 2017-10-09 19:54:12 PDT
Calling fileSystemDirectoryEntry.getDirectory() with empty/null/undefined path should not fail as per:
- https://wicg.github.io/entries-api/#dom-filesystemdirectoryentry-getdirectory

The empty string is a valid path as per:
- https://wicg.github.io/entries-api/#valid-path

This aligns out behavior with Chrome.

Test: http://w3c-test.org/entries-api/filesystemdirectoryentry-getDirectory-manual.html
Comment 1 Chris Dumez 2017-10-09 19:56:17 PDT
Created attachment 323272 [details]
Patch
Comment 2 Ryosuke Niwa 2017-10-09 20:27:28 PDT
Comment on attachment 323272 [details]
Patch

r=me preemptively
Comment 3 WebKit Commit Bot 2017-10-09 21:10:06 PDT
Comment on attachment 323272 [details]
Patch

Clearing flags on attachment: 323272

Committed r223118: <http://trac.webkit.org/changeset/223118>
Comment 4 WebKit Commit Bot 2017-10-09 21:10:08 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2017-10-09 21:10:38 PDT
<rdar://problem/34902704>