Bug 178106

Summary:

Update JavaScriptCore/ucd/CaseFolding.txt to Unicode database 10.0

Product:

WebKit

Reporter:

Michael Saboff <msaboff>

Component:

JavaScriptCore

Assignee:

Michael Saboff <msaboff>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, buildbot, commit-queue, keith_miller, mark.lam, saam, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Michael Saboff 2017-10-09 18:02:28 PDT

Change set r223081 added new Unicode database (UCD) data files to the source tree.  The version of the added files is UCD 10.0.  The UCD file checked in version of Source/JavaScriptCore/CaseFolding.txt is 8.0.  CaseFolding.txt should be updated to 10.0 as well.  This may require updating some tests.

Comment 1 Radar WebKit Bug Importer 2017-10-09 18:04:33 PDT

<rdar://problem/34900035>

Comment 2 Michael Saboff 2017-10-11 10:54:17 PDT

Created attachment 323429 [details]
Patch

Comment 3 Alexey Proskuryakov 2017-10-11 11:09:39 PDT

Comment on attachment 323429 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=323429&action=review

> Source/JavaScriptCore/ChangeLog:3
> +        Update JavaScriptCore/ucd/CaseFolding.txt to Unicode database 10.0

Can this be tested at all?

Comment 4 Michael Saboff 2017-10-11 11:43:22 PDT

(In reply to Alexey Proskuryakov from comment #3)
> Comment on attachment 323429 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=323429&action=review
> 
> > Source/JavaScriptCore/ChangeLog:3
> > +        Update JavaScriptCore/ucd/CaseFolding.txt to Unicode database 10.0
> 
> Can this be tested at all?

We can add new tests for the new case folding rules.  Since the code is data driven and we have tests that cover the transformation, I didn't add any for the new rules.

Comment 5 Keith Miller 2017-10-11 11:46:24 PDT

Comment on attachment 323429 [details]
Patch

rs=me.

Comment 6 WebKit Commit Bot 2017-10-11 12:14:02 PDT

Comment on attachment 323429 [details]
Patch

Clearing flags on attachment: 323429

Committed r223197: <https://trac.webkit.org/changeset/223197>

Comment 7 WebKit Commit Bot 2017-10-11 12:14:04 PDT

All reviewed patches have been landed.  Closing bug.