Summary: | Add isContinuation bit | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Antti Koivisto <koivisto> | ||||||||||||
Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | bfulgham, buildbot, rniwa, simon.fraser, webkit-bug-importer, zalan | ||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||
Hardware: | Unspecified | ||||||||||||||
OS: | Unspecified | ||||||||||||||
Attachments: |
|
Description
Antti Koivisto
2017-10-09 09:49:47 PDT
Created attachment 323180 [details]
patch
Comment on attachment 323180 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=323180&action=review > Source/WebCore/rendering/RenderElement.h:229 > + bool isBlockElementContinuation() const { return isElementContinuation() && !isInline(); } Is it actually used at all? I can't find any callsites on this. > Is it actually used at all? I can't find any callsites on this.
I guess not. I'll get rid of it.
Comment on attachment 323180 [details] patch Attachment 323180 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/4801506 New failing tests: accessibility/mac/css-first-letter-children.html Created attachment 323189 [details]
Archive of layout-test-results from ews103 for mac-elcapitan
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Comment on attachment 323180 [details] patch Attachment 323180 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/4801510 New failing tests: accessibility/mac/css-first-letter-children.html Created attachment 323190 [details]
Archive of layout-test-results from ews104 for mac-elcapitan-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6
Comment on attachment 323180 [details] patch Attachment 323180 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/4801817 New failing tests: accessibility/mac/css-first-letter-children.html Created attachment 323195 [details]
Archive of layout-test-results from ews113 for mac-elcapitan
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Created attachment 323292 [details]
patch
|