Bug 178075

Summary:

RenderObject::destroy() should only be invoked after renderer has been removed from the tree

Product:

WebKit

Reporter:

Antti Koivisto <koivisto>

Component:

Layout and Rendering

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, buildbot, commit-queue, rniwa, simon.fraser, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch	buildbot: commit-queue-
Archive of layout-test-results from ews103 for mac-elcapitan	none
Archive of layout-test-results from ews104 for mac-elcapitan-wk2	none
patch	zalan: review+, buildbot: commit-queue-
Archive of layout-test-results from ews100 for mac-elcapitan	none
Archive of layout-test-results from ews105 for mac-elcapitan-wk2	none
Archive of layout-test-results from ews113 for mac-elcapitan	none
patch	none

Antti Koivisto

Reported 2017-10-09 02:21:00 PDT

Currently we remove it if it still is. We should fix the remaining cases that require this.

Attachments
patch (16.28 KB, patch) 2017-10-09 02:28 PDT, Antti Koivisto	buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews103 for mac-elcapitan (1.03 MB, application/zip) 2017-10-09 03:37 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews104 for mac-elcapitan-wk2 (1.18 MB, application/zip) 2017-10-09 03:45 PDT, Build Bot	no flags	Details
patch (16.28 KB, patch) 2017-10-09 04:05 PDT, Antti Koivisto	zalan: review+ buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews100 for mac-elcapitan (990.46 KB, application/zip) 2017-10-09 05:17 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews105 for mac-elcapitan-wk2 (1.18 MB, application/zip) 2017-10-09 05:23 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews113 for mac-elcapitan (1.77 MB, application/zip) 2017-10-09 10:30 PDT, Build Bot	no flags	Details
patch (17.98 KB, patch) 2017-10-10 04:45 PDT, Antti Koivisto	no flags	Details Formatted Diff Diff
Show Obsolete (7) View All Add attachment proposed patch, testcase, etc.

Antti Koivisto

Comment 1 2017-10-09 02:28:12 PDT

Created attachment 323163 [details] patch

Build Bot

Comment 2 2017-10-09 03:37:49 PDT

Comment on attachment 323163 [details] patch Attachment 323163 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/4798793 New failing tests: accessibility/mac/textbox-role-reports-notifications.html

Build Bot

Comment 3 2017-10-09 03:37:50 PDT

Created attachment 323166 [details] Archive of layout-test-results from ews103 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Build Bot

Comment 4 2017-10-09 03:45:42 PDT

Comment on attachment 323163 [details] patch Attachment 323163 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/4798801 New failing tests: accessibility/mac/textbox-role-reports-notifications.html

Build Bot

Comment 5 2017-10-09 03:45:43 PDT

Created attachment 323167 [details] Archive of layout-test-results from ews104 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6

Antti Koivisto

Comment 6 2017-10-09 04:05:49 PDT

Created attachment 323168 [details] patch

Build Bot

Comment 7 2017-10-09 05:16:59 PDT

Comment on attachment 323168 [details] patch Attachment 323168 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/4799311 New failing tests: accessibility/mac/textbox-role-reports-notifications.html

Build Bot

Comment 8 2017-10-09 05:17:00 PDT

Created attachment 323170 [details] Archive of layout-test-results from ews100 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Build Bot

Comment 9 2017-10-09 05:23:14 PDT

Comment on attachment 323168 [details] patch Attachment 323168 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/4799323 New failing tests: accessibility/mac/textbox-role-reports-notifications.html

Build Bot

Comment 10 2017-10-09 05:23:16 PDT

Created attachment 323171 [details] Archive of layout-test-results from ews105 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6

Build Bot

Comment 11 2017-10-09 10:30:57 PDT

Comment on attachment 323168 [details] patch Attachment 323168 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/4800997 New failing tests: accessibility/mac/textbox-role-reports-notifications.html

Build Bot

Comment 12 2017-10-09 10:30:58 PDT

Created attachment 323186 [details] Archive of layout-test-results from ews113 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews113 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Antti Koivisto

Comment 13 2017-10-10 04:45:33 PDT

Created attachment 323297 [details] patch

WebKit Commit Bot

Comment 14 2017-10-10 06:02:51 PDT

Comment on attachment 323297 [details] patch Clearing flags on attachment: 323297 Committed r223131: <http://trac.webkit.org/changeset/223131>

WebKit Commit Bot

Comment 15 2017-10-10 06:02:53 PDT

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 16 2017-10-10 06:04:07 PDT

<rdar://problem/34909056>

Note You need to log in before you can comment on or make changes to this bug.