Bug 178075 - RenderObject::destroy() should only be invoked after renderer has been removed from the tree
Summary: RenderObject::destroy() should only be invoked after renderer has been remove...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-10-09 02:21 PDT by Antti Koivisto
Modified: 2017-10-10 06:04 PDT (History)
7 users (show)

See Also:

Attachments
patch (16.28 KB, patch)
2017-10-09 02:28 PDT, Antti Koivisto 		buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews103 for mac-elcapitan (1.03 MB, application/zip)
2017-10-09 03:37 PDT, Build Bot 		no flags Details
Archive of layout-test-results from ews104 for mac-elcapitan-wk2 (1.18 MB, application/zip)
2017-10-09 03:45 PDT, Build Bot 		no flags Details
patch (16.28 KB, patch)
2017-10-09 04:05 PDT, Antti Koivisto 		zalan: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews100 for mac-elcapitan (990.46 KB, application/zip)
2017-10-09 05:17 PDT, Build Bot 		no flags Details
Archive of layout-test-results from ews105 for mac-elcapitan-wk2 (1.18 MB, application/zip)
2017-10-09 05:23 PDT, Build Bot 		no flags Details
Archive of layout-test-results from ews113 for mac-elcapitan (1.77 MB, application/zip)
2017-10-09 10:30 PDT, Build Bot 		no flags Details
patch (17.98 KB, patch)
2017-10-10 04:45 PDT, Antti Koivisto 		no flags Details | Formatted Diff | Diff
Show Obsolete (7) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2017-10-09 02:21:00 PDT 
Currently we remove it if it still is. We should fix the remaining cases that require this.
Comment 1 Antti Koivisto 2017-10-09 02:28:12 PDT 
Created attachment 323163 [details]
patch
Comment 2 Build Bot 2017-10-09 03:37:49 PDT 
Comment on attachment 323163 [details]
patch

Attachment 323163 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/4798793

New failing tests:
accessibility/mac/textbox-role-reports-notifications.html
Comment 3 Build Bot 2017-10-09 03:37:50 PDT 
Created attachment 323166 [details]
Archive of layout-test-results from ews103 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 4 Build Bot 2017-10-09 03:45:42 PDT 
Comment on attachment 323163 [details]
patch

Attachment 323163 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/4798801

New failing tests:
accessibility/mac/textbox-role-reports-notifications.html
Comment 5 Build Bot 2017-10-09 03:45:43 PDT 
Created attachment 323167 [details]
Archive of layout-test-results from ews104 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6
Comment 6 Antti Koivisto 2017-10-09 04:05:49 PDT 
Created attachment 323168 [details]
patch
Comment 7 Build Bot 2017-10-09 05:16:59 PDT 
Comment on attachment 323168 [details]
patch

Attachment 323168 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/4799311

New failing tests:
accessibility/mac/textbox-role-reports-notifications.html
Comment 8 Build Bot 2017-10-09 05:17:00 PDT 
Created attachment 323170 [details]
Archive of layout-test-results from ews100 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 9 Build Bot 2017-10-09 05:23:14 PDT 
Comment on attachment 323168 [details]
patch

Attachment 323168 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/4799323

New failing tests:
accessibility/mac/textbox-role-reports-notifications.html
Comment 10 Build Bot 2017-10-09 05:23:16 PDT 
Created attachment 323171 [details]
Archive of layout-test-results from ews105 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6
Comment 11 Build Bot 2017-10-09 10:30:57 PDT 
Comment on attachment 323168 [details]
patch

Attachment 323168 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/4800997

New failing tests:
accessibility/mac/textbox-role-reports-notifications.html
Comment 12 Build Bot 2017-10-09 10:30:58 PDT 
Created attachment 323186 [details]
Archive of layout-test-results from ews113 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 13 Antti Koivisto 2017-10-10 04:45:33 PDT 
Created attachment 323297 [details]
patch
Comment 14 WebKit Commit Bot 2017-10-10 06:02:51 PDT 
Comment on attachment 323297 [details]
patch

Clearing flags on attachment: 323297

Committed r223131: <http://trac.webkit.org/changeset/223131>
Comment 15 WebKit Commit Bot 2017-10-10 06:02:53 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 16 Radar WebKit Bug Importer 2017-10-10 06:04:07 PDT 
<rdar://problem/34909056>