Bug 178068

Summary: Web Inspector: add autocompletion for min/max within a CSS calc
Product: WebKit Reporter: Devin Rousso <hi>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, inspector-bugzilla-changes, joepeck, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch none

Devin Rousso
Reported 2017-10-08 15:04:13 PDT
When typing the following width: calc(m| we should show autocompletions for "min()" and "max()", as they are now supported for CSS calc.
Attachments
Patch (1.60 KB, patch)
2017-10-08 15:04 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Patch (1.61 KB, patch)
2017-10-08 16:33 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Devin Rousso
Comment 1 2017-10-08 15:04:58 PDT
Created attachment 323145 [details] Patch
Joseph Pecoraro
Comment 2 2017-10-08 15:25:18 PDT
Comment on attachment 323145 [details] Patch Heh, I did this the other day and decided against it. I can't remember my reasons though, so lets do it. Can calc be recursive? So should calc be in this list?
Devin Rousso
Comment 3 2017-10-08 16:33:04 PDT
Created attachment 323148 [details] Patch
WebKit Commit Bot
Comment 4 2017-10-08 18:10:47 PDT
Comment on attachment 323148 [details] Patch Clearing flags on attachment: 323148 Committed r223038: <http://trac.webkit.org/changeset/223038>
WebKit Commit Bot
Comment 5 2017-10-08 18:10:48 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2017-10-08 18:11:37 PDT
<rdar://problem/34877729>
Note You need to log in before you can comment on or make changes to this bug.