| Summary: | Update HTMLOListElement.start to behavior from latest HTML specification | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Darin Adler <darin> | ||||||||||||||
| Component: | DOM | Assignee: | Darin Adler <darin> | ||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||
| Severity: | Normal | CC: | buildbot, cdumez, commit-queue, d, esprehn+autocc, gyuyoung.kim, rniwa, sam, webkit-bug-importer | ||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||
| OS: | Unspecified | ||||||||||||||||
| Attachments: |
|
||||||||||||||||
|
Description
Darin Adler
2017-10-07 18:29:30 PDT
Created attachment 323110 [details]
Patch
*** Bug 163752 has been marked as a duplicate of this bug. *** I was waiting for the Chrome UseCounter data to determine if it was safe. Looks like they have UseCounter data now: https://www.chromestatus.com/metrics/feature/timeline/popularity/2011 And they decided it was safe enough to make the change via: https://bugs.chromium.org/p/chromium/issues/detail?id=657972 Thanks for the review and confirmation that it’s OK to make this change. I’d really love to have the EWS confirm the tests pass before I land this. Comment on attachment 323110 [details] Patch Rejecting attachment 323110 [details] from commit-queue. New failing tests: fast/lists/ol-reversed-simple.html fast/lists/ol-reversed-simple.xhtml Full output: http://webkit-queues.webkit.org/results/4793379 Created attachment 323133 [details]
Archive of layout-test-results from webkit-cq-02 for mac-elcapitan
The attached test failures were seen while running run-webkit-tests on the commit-queue.
Bot: webkit-cq-02 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Comment on attachment 323110 [details] Patch Attachment 323110 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/4794048 New failing tests: fast/lists/ol-reversed-simple.html fast/lists/ol-reversed-simple.xhtml Created attachment 323135 [details]
Archive of layout-test-results from ews100 for mac-elcapitan
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Comment on attachment 323110 [details] Patch Attachment 323110 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/4794057 New failing tests: fast/lists/ol-reversed-simple.html fast/lists/ol-reversed-simple.xhtml Created attachment 323136 [details]
Archive of layout-test-results from ews107 for mac-elcapitan-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6
Comment on attachment 323110 [details] Patch Attachment 323110 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/4794015 New failing tests: fast/lists/ol-reversed-simple.html fast/lists/ol-reversed-simple.xhtml Created attachment 323137 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.6
Comment on attachment 323110 [details] Patch Attachment 323110 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/4794188 New failing tests: fast/lists/ol-reversed-simple.html fast/lists/ol-reversed-simple.xhtml Created attachment 323140 [details]
Archive of layout-test-results from ews112 for mac-elcapitan
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Committed r223036: <http://trac.webkit.org/changeset/223036> |