Summary: | Reduce includes in Document.h | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Alex Christensen <achristensen> | ||||||
Component: | New Bugs | Assignee: | Alex Christensen <achristensen> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | benjamin, buildbot, cdumez, cmarcelo, darin, dbates, esprehn+autocc, kangil.han, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Alex Christensen
2017-10-06 16:12:48 PDT
Created attachment 323060 [details]
Patch
Attachment 323060 [details] did not pass style-queue:
ERROR: Source/WTF/wtf/HashCountedSet.h:290: This { should be at the end of the previous line [whitespace/braces] [4]
ERROR: Source/WTF/wtf/HashCountedSet.h:297: This { should be at the end of the previous line [whitespace/braces] [4]
ERROR: Source/WTF/wtf/HashCountedSet.h:304: This { should be at the end of the previous line [whitespace/braces] [4]
ERROR: Source/WTF/wtf/HashCountedSet.h:311: This { should be at the end of the previous line [whitespace/braces] [4]
ERROR: Source/WTF/wtf/HashCountedSet.h:318: This { should be at the end of the previous line [whitespace/braces] [4]
ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5]
ERROR: Source/WTF/wtf/Forward.h:34: More than one command on the same line [whitespace/newline] [4]
Total errors found: 7 in 5 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 323099 [details]
Patch
Comment on attachment 323099 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=323099&action=review > Source/WebCore/dom/Document.h:186 > +template<typename> class ExceptionOr; Should probably do this in a lot of other files. |