Bug 178032

Summary: Teach InlineTextBox::clampOffset() about combined text and hyphenation
Product: WebKit Reporter: Daniel Bates <dbates>
Component: Layout and RenderingAssignee: Daniel Bates <dbates>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, mmaxfield, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 138913, 178322    
Attachments:
Description Flags
Patch
none
Patch zalan: review+

Daniel Bates
Reported 2017-10-06 15:27:47 PDT
As a first steps towards fixing bug #138913, teach InlineTextBox::clampOffset() about combined text and hyphenation.
Attachments
Patch (11.21 KB, patch)
2017-10-06 16:24 PDT, Daniel Bates 		no flags
DetailsFormatted DiffDiff
Patch (11.72 KB, patch)
2017-10-09 10:08 PDT, Daniel Bates 		zalan: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Daniel Bates
Comment 1 2017-10-06 16:24:05 PDT
Created attachment 323062 [details] Patch
Daniel Bates
Comment 2 2017-10-09 10:08:41 PDT
Created attachment 323183 [details] Patch
Daniel Bates
Comment 3 2017-10-12 08:41:28 PDT
Comment on attachment 323183 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=323183&action=review > Source/WebCore/rendering/InlineTextBox.cpp:629 > + // Fix up the offset if we are combined text or have a hyphen. We treat combined text as a Will update this comment to read: Fix up the offset if we are combined text or have a hyphen because we manage these embellishments. That is, they are not reflected in renderer().text(). We treat combined text as a single unit. We also treat the last codepoint in this box and the hyphen as a single unit.
Daniel Bates
Comment 4 2017-10-12 14:31:45 PDT
Committed r223259: <https://trac.webkit.org/changeset/223259>
Radar WebKit Bug Importer
Comment 5 2017-10-12 14:32:41 PDT
<rdar://problem/34964018>
Note You need to log in before you can comment on or make changes to this bug.