Summary: | [iOS] Layout Test http/tests/preload/viewport/meta-viewport-link-headers.php is flaky | ||
---|---|---|---|
Product: | WebKit | Reporter: | Matt Lewis <jlewis3> |
Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> |
Status: | NEW --- | ||
Severity: | Normal | CC: | ap, ryanhaddad, yoav, youennf |
Priority: | P2 | ||
Version: | WebKit Nightly Build | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=172518 |
Description
Matt Lewis
2017-10-06 14:46:28 PDT
Yoav, would you be willing to take a look? Apparently the fix in bug 172518 wasn't sufficient. I don't know if that's the cause of flakiness, but this test uses a common anti-pattern. The test starts before the document is completely loaded, so loading the image races with completing the document load. The assignment to img.src should happen no earlier than window.onload. Also, instead of waiting for a second, the test can use shouldBecomeTrue from WebKit test harness (or an equivalent from W3C harness if it exists). Looking at the test, it might be missing a return after line 34. As of the 1 second thing, since it is polling repetitively several times, I don't think there is an issue there. It only polls for one second, and the load may not complete so quickly. Marked test as flaky in https://trac.webkit.org/changeset/224355/webkit |