Bug 178015

Summary: Web Inspector: Network Tab - Row wrapping (waterfall displaying behind next row's name)
Product: WebKit Reporter: Blaze Burg <bburg>
Component: Web InspectorAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, inspector-bugzilla-changes, joepeck, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
[SCREENSHOT] unexpanded table
none
[SCREENSHOT] selected a row
none
[PATCH] Proposed Fix bburg: review+

Blaze Burg
Reported 2017-10-06 10:21:24 PDT
This goes away when selecting a table row. Probably bad CSS?
Attachments
[SCREENSHOT] unexpanded table (533.89 KB, image/png)
2017-10-06 10:21 PDT, Blaze Burg 		no flags
Details
[SCREENSHOT] selected a row (306.32 KB, image/png)
2017-10-06 10:22 PDT, Blaze Burg 		no flags
Details
[PATCH] Proposed Fix (1.45 KB, patch)
2017-10-08 14:58 PDT, Joseph Pecoraro 		bburg: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Blaze Burg
Comment 1 2017-10-06 10:21:45 PDT
Created attachment 323024 [details] [SCREENSHOT] unexpanded table
Blaze Burg
Comment 2 2017-10-06 10:22:44 PDT
Created attachment 323025 [details] [SCREENSHOT] selected a row
Blaze Burg
Comment 3 2017-10-06 10:23:14 PDT
This happens for me on my iMac 5K retina screen.
Joseph Pecoraro
Comment 4 2017-10-06 10:26:26 PDT
On non-retina this only happens at super small widths (where the min-size of a column is not taken into account for columnWidths). Here it appears to happen at a wide width, so I suspect this because Retina has half pixel borders and the total width is calculated incorrectly. I'll look into this soon.
Radar WebKit Bug Importer
Comment 5 2017-10-06 10:27:24 PDT
<rdar://problem/34858720>
Joseph Pecoraro
Comment 6 2017-10-08 14:58:20 PDT
Created attachment 323144 [details] [PATCH] Proposed Fix This fixes the issue for me on non-Retina. I'll have to test this on Retina before landing though to make sure I addressed the actual original issue.
Joseph Pecoraro
Comment 7 2017-10-09 11:19:40 PDT
Comment on attachment 323144 [details] [PATCH] Proposed Fix Looks good on Retina.
Blaze Burg
Comment 8 2017-10-09 11:23:46 PDT
Comment on attachment 323144 [details] [PATCH] Proposed Fix r=me, verified on retina machine.
Joseph Pecoraro
Comment 9 2017-10-09 12:33:14 PDT
<https://trac.webkit.org/r223059>
Note You need to log in before you can comment on or make changes to this bug.