Summary: | Always invoke RenderObject::insertedIntoTree/willBeRemovedFromTree | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Antti Koivisto <koivisto> | ||||||||||||
Component: | Layout and Rendering | Assignee: | zalan <zalan> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | aakash_jain, ap, bfulgham, buildbot, commit-queue, jbedard, jlewis3, simon.fraser, webkit-bug-importer, zalan | ||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||
Hardware: | Unspecified | ||||||||||||||
OS: | Unspecified | ||||||||||||||
Attachments: |
|
Description
Antti Koivisto
2017-10-06 05:27:45 PDT
Created attachment 323010 [details]
patch
Comment on attachment 323010 [details] patch Attachment 323010 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/4787643 Number of test failures exceeded the failure limit. Created attachment 323084 [details]
Archive of layout-test-results from ews115 for mac-elcapitan
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Surprisingly, a lot of EWS bots (e.g.: ews101, ews102, ews106, ews107, ews112, ews113, ews115, ews121, ews122, ews124) got stuck while running tests on this patch. Last log on bots: Running: webkit-patch --status-host=webkit-queues.webkit.org --bot-id=ews121 build-and-test --no-clean --no-update --test --non-interactive --build-style=release --group=None --port=ios-simulator-wk2 When the windows EWS bots hit this patch again, it caused them to stop again in the build phase. As such there is no build log created. ImageDiff seems to be stuck for few hours on this bot (bot205). Tracking the EWS issue as <rdar://problem/34917666>. Created attachment 327049 [details]
Patch
Created attachment 327081 [details]
Patch
Comment on attachment 327081 [details]
Patch
Nice
Comment on attachment 327081 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=327081&action=review > Source/WebCore/rendering/RenderBoxModelObject.h:280 > + enum class NormalizeAfterInsertion { No, Yes }; This could use a comment explaining what the values mean. Created attachment 327091 [details]
Patch
The commit-queue encountered the following flaky tests while processing attachment 327091 [details]: http/tests/security/cross-origin-xsl-BLOCKED.html bug 51054 (authors: abarth@webkit.org, jochen@chromium.org, and rniwa@webkit.org) The commit-queue is continuing to process your patch. Comment on attachment 327091 [details] Patch Clearing flags on attachment: 327091 Committed r224933: <https://trac.webkit.org/changeset/224933> All reviewed patches have been landed. Closing bug. |