Bug 178000

Summary:

[WinCairo] Add WebKit platform files for wincairo webkit

Product:

WebKit

Reporter:

Yousuke Kimoto <Yousuke.Kimoto>

Component:

WebKit2

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, andersca, bfulgham, buildbot, commit-queue, don.olmstead, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
[PATCH] WebKit platform files for wincairo webkit	none
[PATCH] WebKit platform files for wincairo webkit	none
[PATCH] WebKit platform files for wincairo webkit	none

Yousuke Kimoto

Reported 2017-10-06 01:22:16 PDT

Add files under WebKit/Platform for wincairo webkit.

Attachments
[PATCH] WebKit platform files for wincairo webkit (16.41 KB, patch) 2017-10-06 06:11 PDT, Yousuke Kimoto	no flags	Details Formatted Diff Diff
[PATCH] WebKit platform files for wincairo webkit (16.46 KB, patch) 2017-10-12 23:11 PDT, Yousuke Kimoto	no flags	Details Formatted Diff Diff
[PATCH] WebKit platform files for wincairo webkit (16.51 KB, patch) 2017-10-13 09:12 PDT, Yousuke Kimoto	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Yousuke Kimoto

Comment 1 2017-10-06 06:11:41 PDT

Created attachment 323014 [details] [PATCH] WebKit platform files for wincairo webkit

Anders Carlsson

Comment 2 2017-10-06 09:07:06 PDT

I don't think these files have the right copyright headers - there are comments referring to old bugs such as https://bugs.webkit.org/show_bug.cgi?id=47502.

Yousuke Kimoto

Comment 3 2017-10-12 23:11:02 PDT

Created attachment 323641 [details] [PATCH] WebKit platform files for wincairo webkit Copyrights which are used in LoggingWin.cpp, ModuleWin.cpp and SharedMemoryWin.cpp are fixed.

Build Bot

Comment 4 2017-10-12 23:14:22 PDT

Attachment 323641 [details] did not pass style-queue: ERROR: Source/WebKit/PlatformWin.cmake:24: Alphabetical sorting problem. "Platform/win/LoggingWin.cpp" should be before "Shared/curl/WebCoreArgumentCodersCurl.cpp". [list/order] [5] Total errors found: 1 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.

Yousuke Kimoto

Comment 5 2017-10-13 09:12:29 PDT

Created attachment 323678 [details] [PATCH] WebKit platform files for wincairo webkit Fixed a style check error.

Alex Christensen

Comment 6 2017-10-25 11:13:40 PDT

Comment on attachment 323678 [details] [PATCH] WebKit platform files for wincairo webkit View in context: https://bugs.webkit.org/attachment.cgi?id=323678&action=review > Source/WebKit/Platform/win/LoggingWin.cpp:50 > + return String(buffer.get()); Is buffer null-terminated? Could we use length here?

WebKit Commit Bot

Comment 7 2017-10-25 11:38:52 PDT

Comment on attachment 323678 [details] [PATCH] WebKit platform files for wincairo webkit Clearing flags on attachment: 323678 Committed r223966: <https://trac.webkit.org/changeset/223966>

WebKit Commit Bot

Comment 8 2017-10-25 11:38:53 PDT

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 9 2017-11-15 13:12:37 PST

<rdar://problem/35569011>

Note You need to log in before you can comment on or make changes to this bug.