Bug 177989 – Web Inspector: Improve setting the default / initial sort of a Table

• Component: Web Inspector
• Status: RESOLVED FIXED

[Joseph Pecoraro]

Improve setting the default / initial sort of a Table

Its hard / impossible to set the initial sort of a Table. Lets make it easier and better.

    let table = new Table(identifier, ...);
    if (!table.sortColumnIdentifier) {
        table.sortOrder = ...;
        table.sortColumnIdentifier = ...;
    }

The initialLayout of the table will ensure it displays appropriately.

[Joseph Pecoraro]

Created attachment 322980 [details]
[PATCH] Proposed Fix

I like this approach for setting up the default sort. Its easy to find and not too invasive in code. It probably depends on ordering (ensure columns are added before setting the default sort) but thats a pattern I'm already following and encouraging.

[Blaze Burg]

Comment on attachment 322980 [details]
[PATCH] Proposed Fix

r=me

[WebKit Commit Bot]

Comment on attachment 322980 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 322980

Committed r222983: <http://trac.webkit.org/changeset/222983>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/34857354>