Bug 177987

Summary: We don't need to clearEmptyObjectStructureForPrototype because JSGlobalObject* is part of the cache's key
Product: WebKit Reporter: Saam Barati <saam>
Component: JavaScriptCoreAssignee: Saam Barati <saam>
Severity: Normal CC: ashwinkumar9944, benjamin, buildbot, commit-queue, fpizlo, ggaren, gskachkov, jfbastien, keith_miller, mark.lam, msaboff, rmorisset, ticaiolima, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: Safari Technology Preview   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 177907    
Description Flags
test EWS
fpizlo: review+
patch for landing none

Description Saam Barati 2017-10-05 18:58:11 PDT
Going to run some stuff on EWS to see what happens.

Geoff, any idea why we have this? Is it an optimization or needed for correctness?
Comment 1 Saam Barati 2017-10-05 19:11:26 PDT
Created attachment 322965 [details]
test EWS
Comment 2 Build Bot 2017-10-05 19:12:51 PDT
Attachment 322965 [details] did not pass style-queue:

ERROR: Source/JavaScriptCore/runtime/PrototypeMap.cpp:84:  Should have a space between // and comment  [whitespace/comments] [4]
ERROR: Source/JavaScriptCore/runtime/PrototypeMap.cpp:85:  Should have a space between // and comment  [whitespace/comments] [4]
Total errors found: 2 in 1 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Saam Barati 2017-10-09 18:47:42 PDT
Created attachment 323265 [details]
Comment 4 Saam Barati 2017-10-09 19:55:15 PDT
Created attachment 323271 [details]
patch for landing
Comment 5 WebKit Commit Bot 2017-10-09 22:11:31 PDT
Comment on attachment 323271 [details]
patch for landing

Clearing flags on attachment: 323271

Committed r223123: <http://trac.webkit.org/changeset/223123>
Comment 6 WebKit Commit Bot 2017-10-09 22:11:32 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2017-10-09 22:12:08 PDT