| Summary: | We don't need to clearEmptyObjectStructureForPrototype because JSGlobalObject* is part of the cache's key | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Saam Barati <saam> | ||||||||
| Component: | JavaScriptCore | Assignee: | Saam Barati <saam> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | ashwinkumar9944, benjamin, buildbot, commit-queue, fpizlo, ggaren, gskachkov, jfbastien, keith_miller, mark.lam, msaboff, rmorisset, ticaiolima, webkit-bug-importer, ysuzuki | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | Safari Technology Preview | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Bug Depends on: | |||||||||||
| Bug Blocks: | 177907 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Saam Barati
2017-10-05 18:58:11 PDT
Created attachment 322965 [details]
test EWS
Attachment 322965 [details] did not pass style-queue:
ERROR: Source/JavaScriptCore/runtime/PrototypeMap.cpp:84: Should have a space between // and comment [whitespace/comments] [4]
ERROR: Source/JavaScriptCore/runtime/PrototypeMap.cpp:85: Should have a space between // and comment [whitespace/comments] [4]
Total errors found: 2 in 1 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 323265 [details]
patch
Created attachment 323271 [details]
patch for landing
Comment on attachment 323271 [details] patch for landing Clearing flags on attachment: 323271 Committed r223123: <http://trac.webkit.org/changeset/223123> All reviewed patches have been landed. Closing bug. |