Bug 177970

Summary: Win EWS bots should reboot after N webkit-patch iterations.
Product: WebKit Reporter: Per Arne Vollan <pvollan>
Component: Tools / TestsAssignee: Per Arne Vollan <pvollan>
Status: REOPENED    
Severity: Normal CC: achristensen, ap, bfulgham, commit-queue, lforschler, ryanhaddad, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Per Arne Vollan
Reported 2017-10-05 14:49:19 PDT
I believe the macOS EWS bots reboot after webkit-patch has processed N patches.
Attachments
Patch (3.32 KB, patch)
2017-10-05 14:51 PDT, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Per Arne Vollan
Comment 1 2017-10-05 14:51:36 PDT
Created attachment 322920 [details] Patch
Ryan Haddad
Comment 2 2017-10-05 15:09:26 PDT
I know we have seen Windows EWS bots require a manual log in before coming back online in the past. Do we think this will still be an issue?
Per Arne Vollan
Comment 3 2017-10-05 15:16:09 PDT
(In reply to Ryan Haddad from comment #2) > I know we have seen Windows EWS bots require a manual log in before coming > back online in the past. Do we think this will still be an issue? I believe we have fixed this by enabling auto-login again.
Ryan Haddad
Comment 4 2017-10-05 16:05:38 PDT
(In reply to Per Arne Vollan from comment #3) > (In reply to Ryan Haddad from comment #2) > > I know we have seen Windows EWS bots require a manual log in before coming > > back online in the past. Do we think this will still be an issue? > > I believe we have fixed this by enabling auto-login again. Ah, that would do it. I made this change for the macOS EWS bots to try to prevent them from getting into weird states with stuck processes. If we think the reboots benefit Windows EWS, this looks good to me.
Ryan Haddad
Comment 5 2017-11-13 17:22:13 PST
I hit a case today where a Windows EWS bot needed 'svn cleanup' to be run. This change would have allowed the bot to recover itself after a few more runs without my intervention. Any reviewers willing to r+ this?
Brent Fulgham
Comment 6 2017-11-13 18:42:37 PST
Comment on attachment 322920 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=322920&action=review > Tools/ChangeLog:3 > + Win EWS bots should reboot after N webkit-patch iterations. It looks like N in this case is 1. If you think EWS will keep up with the change, r=me
Per Arne Vollan
Comment 7 2017-11-16 07:32:52 PST
Comment on attachment 322920 [details] Patch Thanks for reviewing!
WebKit Commit Bot
Comment 8 2017-11-16 07:52:32 PST
Comment on attachment 322920 [details] Patch Clearing flags on attachment: 322920 Committed r224920: <https://trac.webkit.org/changeset/224920>
WebKit Commit Bot
Comment 9 2017-11-16 07:52:33 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 10 2017-11-16 07:53:16 PST
<rdar://problem/35588672>
Per Arne Vollan
Comment 11 2018-01-26 09:16:33 PST
Rolled out in <https://trac.webkit.org/changeset/227679/webkit>. Some EWS bots are not coming back online after initiating reboot.
Note You need to log in before you can comment on or make changes to this bug.