| Summary: | Win EWS bots should reboot after N webkit-patch iterations. | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Per Arne Vollan <pvollan> | ||||
| Component: | Tools / Tests | Assignee: | Per Arne Vollan <pvollan> | ||||
| Status: | REOPENED --- | ||||||
| Severity: | Normal | CC: | achristensen, ap, bfulgham, commit-queue, lforschler, ryanhaddad, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Per Arne Vollan
2017-10-05 14:49:19 PDT
Created attachment 322920 [details]
Patch
I know we have seen Windows EWS bots require a manual log in before coming back online in the past. Do we think this will still be an issue? (In reply to Ryan Haddad from comment #2) > I know we have seen Windows EWS bots require a manual log in before coming > back online in the past. Do we think this will still be an issue? I believe we have fixed this by enabling auto-login again. (In reply to Per Arne Vollan from comment #3) > (In reply to Ryan Haddad from comment #2) > > I know we have seen Windows EWS bots require a manual log in before coming > > back online in the past. Do we think this will still be an issue? > > I believe we have fixed this by enabling auto-login again. Ah, that would do it. I made this change for the macOS EWS bots to try to prevent them from getting into weird states with stuck processes. If we think the reboots benefit Windows EWS, this looks good to me. I hit a case today where a Windows EWS bot needed 'svn cleanup' to be run. This change would have allowed the bot to recover itself after a few more runs without my intervention. Any reviewers willing to r+ this? Comment on attachment 322920 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=322920&action=review > Tools/ChangeLog:3 > + Win EWS bots should reboot after N webkit-patch iterations. It looks like N in this case is 1. If you think EWS will keep up with the change, r=me Comment on attachment 322920 [details]
Patch
Thanks for reviewing!
Comment on attachment 322920 [details] Patch Clearing flags on attachment: 322920 Committed r224920: <https://trac.webkit.org/changeset/224920> All reviewed patches have been landed. Closing bug. Rolled out in <https://trac.webkit.org/changeset/227679/webkit>. Some EWS bots are not coming back online after initiating reboot. |