Summary: | EWS should run Windows tests. | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Per Arne Vollan <pvollan> | ||||
Component: | Tools / Tests | Assignee: | Per Arne Vollan <pvollan> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | aakash_jain, achristensen, ap, bfulgham, buildbot, commit-queue, glenn, jlewis3, lforschler, ryanhaddad, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Per Arne Vollan
2017-10-05 14:15:14 PDT
Created attachment 322915 [details]
Patch
Comment on attachment 322915 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=322915&action=review > Tools/Scripts/webkitpy/common/config/ews.json:13 > + "runTests": true Do we have enough hardware set up for Windows EWS already? (In reply to Alexey Proskuryakov from comment #3) > Comment on attachment 322915 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=322915&action=review > > > Tools/Scripts/webkitpy/common/config/ews.json:13 > > + "runTests": true > > Do we have enough hardware set up for Windows EWS already? Yes, I believe so, although it wouldn't hurt to get more :) I think I overestimated the extra time this would add to the total processing time. It adds 10-12 minutes for each EWS pass. I see. Leaving this for Lucas to r+, and to face the consequences :) (In reply to Alexey Proskuryakov from comment #5) > I see. Leaving this for Lucas to r+, and to face the consequences :) Sounds good :) Thanks! I spoke with Alexey this morning. We discussed moving all Windows EWS bots to SSDs before turning this on. I’ll be tracking that in <rdar://problem/34891365> Check EWS hardware, find units that need SSD (In reply to Lucas Forschler from comment #7) > I spoke with Alexey this morning. We discussed moving all Windows EWS bots > to SSDs before turning this on. > > I’ll be tracking that in > <rdar://problem/34891365> Check EWS hardware, find units that need SSD Great, thank you! Comment on attachment 322915 [details] Patch Clearing flags on attachment: 322915 Committed r228383: <https://trac.webkit.org/changeset/228383> All reviewed patches have been landed. Closing bug. |