Bug 177955 – AX: [ATK] Explicitly-set aria-sort value of "none" should be exposed as an object attribute

• Component: Accessibility
• Status: RESOLVED FIXED

[Joanmarie Diggs]

Currently we are not exposing the aria-sort value when it is "none", but the Core AAM states that when the value is none and has been explicitly set, we should expose it.

[Radar WebKit Bug Importer]

<rdar://problem/34838470>

[Joanmarie Diggs]

Created attachment 322867 [details]
Patch

[chris fleizach]

Comment on attachment 322867 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=322867&action=review

> Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp:513
> +    if (sortDirection != SortDirectionInvalid && coreObject->hasAttribute(HTMLNames::aria_sortAttr)) {

can you use a switch statement here. should be a bit cleaner

[Joanmarie Diggs]

(In reply to chris fleizach from comment #3)
> Comment on attachment 322867 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=322867&action=review
> 
> > Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp:513
> > +    if (sortDirection != SortDirectionInvalid && coreObject->hasAttribute(HTMLNames::aria_sortAttr)) {
> 
> can you use a switch statement here. should be a bit cleaner

Will do. Waiting to get the test failures for your platform out of EWS (traveling, and thus away from my Mac).

[Build Bot]

Comment on attachment 322867 [details]
Patch

Attachment 322867 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/4770595

New failing tests:
accessibility/plugin.html
accessibility/mac/bounds-for-range.html
accessibility/image-link.html
accessibility/mac/internal-link-anchors.html
accessibility/internal-link-anchors2.html
accessibility/mac/document-links.html
accessibility/table-with-rules.html
accessibility/mac/document-attributes.html
accessibility/table-one-cell.html
accessibility/table-sections.html
accessibility/table-cells.html
accessibility/image-map2.html
accessibility/table-cell-spans.html
accessibility/table-attributes.html
accessibility/transformed-element.html
accessibility/math-multiscript-attributes.html
accessibility/parent-delete.html
accessibility/lists.html

[Build Bot]

Created attachment 322883 [details]
Archive of layout-test-results from ews102 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 322867 [details]
Patch

Attachment 322867 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/4770734

New failing tests:
accessibility/plugin.html
accessibility/mac/bounds-for-range.html
accessibility/image-link.html
accessibility/parent-delete.html
accessibility/mac/internal-link-anchors.html
accessibility/mac/document-links.html
accessibility/table-with-rules.html
accessibility/math-multiscript-attributes.html
accessibility/table-one-cell.html
accessibility/transformed-element.html
accessibility/table-cells.html
accessibility/table-sections.html
accessibility/table-cell-spans.html
accessibility/lists.html
accessibility/table-attributes.html
accessibility/mac/document-attributes.html
accessibility/internal-link-anchors2.html
accessibility/image-map2.html

[Build Bot]

Created attachment 322884 [details]
Archive of layout-test-results from ews105 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[Joanmarie Diggs]

Created attachment 322887 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 322887 [details]
Patch

Clearing flags on attachment: 322887

Committed r223048: <http://trac.webkit.org/changeset/223048>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.