Summary: | AX: [ATK] STATE_CHECKABLE should be removed from radio buttons in radiogroups with aria-readonly="true" | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Joanmarie Diggs <jdiggs> | ||||
Component: | Accessibility | Assignee: | Joanmarie Diggs <jdiggs> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | aboxhall, apinheiro, buildbot, cfleizach, commit-queue, dmazzoni, jcraig, samuel_white, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | All | ||||||
OS: | Linux | ||||||
Attachments: |
|
Description
Joanmarie Diggs
2017-10-05 04:13:05 PDT
Created attachment 322820 [details]
Patch
Comment on attachment 322820 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=322820&action=review > Source/WebCore/accessibility/AccessibilityNodeObject.cpp:2107 > + return radioGroup ? radioGroup->ariaReadOnlyValue() != "true" : true; do we want to do equalIgnoringCase() for the != true (In reply to chris fleizach from comment #3) > Comment on attachment 322820 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=322820&action=review > > > Source/WebCore/accessibility/AccessibilityNodeObject.cpp:2107 > > + return radioGroup ? radioGroup->ariaReadOnlyValue() != "true" : true; > > do we want to do equalIgnoringCase() for the != true In this case I don't believe it is necessary: ariaReadOnlyValue() applies convertToASCIILowercase() to the value being returned. Comment on attachment 322820 [details] Patch Clearing flags on attachment: 322820 Committed r223126: <http://trac.webkit.org/changeset/223126> All reviewed patches have been landed. Closing bug. |