Bug 177928

Summary:

Make RealtimeIncomingAudioSources and RealtimeOutgoingAudioSources port agnostic

Product:

WebKit

Reporter:

Alejandro G. Castro <alex>

Component:

WebRTC

Assignee:

Alejandro G. Castro <alex>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, webkit-bug-importer, youennf

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch for landing	none
Patch for landing	none

Alejandro G. Castro

Reported 2017-10-05 03:42:28 PDT

We need this in the GTK port in order to use libwebrtc backend and endpoint classes.

Attachments
Patch (71.61 KB, patch) 2017-10-05 04:00 PDT, Alejandro G. Castro	no flags	Details Formatted Diff Diff
Patch (69.18 KB, patch) 2017-10-12 22:08 PDT, Alejandro G. Castro	no flags	Details Formatted Diff Diff
Patch (69.17 KB, patch) 2017-10-12 22:25 PDT, Alejandro G. Castro	no flags	Details Formatted Diff Diff
Patch (69.09 KB, patch) 2017-10-13 09:08 PDT, Alejandro G. Castro	no flags	Details Formatted Diff Diff
Patch (69.02 KB, patch) 2017-10-13 09:15 PDT, Alejandro G. Castro	no flags	Details Formatted Diff Diff
Patch (69.04 KB, patch) 2017-10-13 09:28 PDT, Alejandro G. Castro	no flags	Details Formatted Diff Diff
Patch (69.03 KB, patch) 2017-10-13 09:35 PDT, Alejandro G. Castro	no flags	Details Formatted Diff Diff
Patch (69.04 KB, patch) 2017-10-13 09:51 PDT, Alejandro G. Castro	no flags	Details Formatted Diff Diff
Patch (69.05 KB, patch) 2017-10-13 10:12 PDT, Alejandro G. Castro	no flags	Details Formatted Diff Diff
Patch (69.05 KB, patch) 2017-10-13 10:25 PDT, Alejandro G. Castro	no flags	Details Formatted Diff Diff
Patch (69.05 KB, patch) 2017-10-13 10:45 PDT, Alejandro G. Castro	no flags	Details Formatted Diff Diff
Patch (68.99 KB, patch) 2017-10-13 11:01 PDT, Alejandro G. Castro	no flags	Details Formatted Diff Diff
Patch (68.98 KB, patch) 2017-10-13 11:48 PDT, Alejandro G. Castro	no flags	Details Formatted Diff Diff
Patch (68.98 KB, patch) 2017-10-13 13:47 PDT, Alejandro G. Castro	no flags	Details Formatted Diff Diff
Patch for landing (69.00 KB, patch) 2017-10-16 07:16 PDT, Alejandro G. Castro	no flags	Details Formatted Diff Diff
Patch for landing (69.12 KB, patch) 2017-10-16 09:01 PDT, Alejandro G. Castro	no flags	Details Formatted Diff Diff
Show Obsolete (15) View All Add attachment proposed patch, testcase, etc.

Alejandro G. Castro

Comment 1 2017-10-05 04:00:56 PDT

Created attachment 322814 [details] Patch

youenn fablet

Comment 2 2017-10-05 04:39:53 PDT

Comment on attachment 322814 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=322814&action=review LGTM, with the same comments as its sister patch. > Source/WebCore/platform/mediastream/mac/RealtimeIncomingAudioSourceMac.cpp:70 > + // FIXME: For the moment we skip them, we should find a better solution at libwebrtc level to not be called until getting some real data. I would be interested to see whether GTK port will have the same issue here or not. Maybe this issue is coming from the libwebrtc WebKit/Mac audio rendering integration.

Alejandro G. Castro

Comment 3 2017-10-12 22:08:49 PDT

Created attachment 323635 [details] Patch

Alejandro G. Castro

Comment 4 2017-10-12 22:25:52 PDT

Created attachment 323638 [details] Patch

Alejandro G. Castro

Comment 5 2017-10-13 09:08:14 PDT

Created attachment 323677 [details] Patch

Alejandro G. Castro

Comment 6 2017-10-13 09:15:30 PDT

Created attachment 323679 [details] Patch

Alejandro G. Castro

Comment 7 2017-10-13 09:28:26 PDT

Created attachment 323681 [details] Patch

Alejandro G. Castro

Comment 8 2017-10-13 09:35:52 PDT

Created attachment 323684 [details] Patch

Alejandro G. Castro

Comment 9 2017-10-13 09:51:46 PDT

Created attachment 323687 [details] Patch

Alejandro G. Castro

Comment 10 2017-10-13 10:12:35 PDT

Created attachment 323689 [details] Patch

Alejandro G. Castro

Comment 11 2017-10-13 10:25:09 PDT

Created attachment 323694 [details] Patch

Alejandro G. Castro

Comment 12 2017-10-13 10:45:19 PDT

Created attachment 323699 [details] Patch

Alejandro G. Castro

Comment 13 2017-10-13 11:01:11 PDT

Created attachment 323706 [details] Patch

Alejandro G. Castro

Comment 14 2017-10-13 11:48:47 PDT

Created attachment 323715 [details] Patch

Alejandro G. Castro

Comment 15 2017-10-13 13:47:46 PDT

Created attachment 323739 [details] Patch

youenn fablet

Comment 16 2017-10-13 16:28:33 PDT

Comment on attachment 323739 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=323739&action=review > Source/WebCore/platform/mediastream/mac/RealtimeIncomingAudioSourceCocoa.cpp:61 > + Double line

Alejandro G. Castro

Comment 17 2017-10-16 07:16:13 PDT

Created attachment 323892 [details] Patch for landing

WebKit Commit Bot

Comment 18 2017-10-16 07:56:03 PDT

Comment on attachment 323892 [details] Patch for landing Rejecting attachment 323892 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 323892, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: .webkit.org/git/WebKit b9f4d12..9032476 master -> origin/master Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ... Currently at 223389 = b9f4d12279749dd6113b170a020ca3bd5ea37fe0 r223406 = 9032476984cacdd3aaf521d9babf7105e2c5f8c3 Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Full output: http://webkit-queues.webkit.org/results/4871101

Alejandro G. Castro

Comment 19 2017-10-16 09:01:05 PDT

Created attachment 323898 [details] Patch for landing

WebKit Commit Bot

Comment 20 2017-10-16 09:40:51 PDT

Comment on attachment 323898 [details] Patch for landing Clearing flags on attachment: 323898 Committed r223412: <https://trac.webkit.org/changeset/223412>

WebKit Commit Bot

Comment 21 2017-10-16 09:40:53 PDT

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 22 2017-10-16 09:41:49 PDT

<rdar://problem/35007894>

Note You need to log in before you can comment on or make changes to this bug.