We need this in the GTK port in order to use libwebrtc backend and endpoint classes.
Created attachment 322814 [details] Patch
Comment on attachment 322814 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=322814&action=review LGTM, with the same comments as its sister patch. > Source/WebCore/platform/mediastream/mac/RealtimeIncomingAudioSourceMac.cpp:70 > + // FIXME: For the moment we skip them, we should find a better solution at libwebrtc level to not be called until getting some real data. I would be interested to see whether GTK port will have the same issue here or not. Maybe this issue is coming from the libwebrtc WebKit/Mac audio rendering integration.
Created attachment 323635 [details] Patch
Created attachment 323638 [details] Patch
Created attachment 323677 [details] Patch
Created attachment 323679 [details] Patch
Created attachment 323681 [details] Patch
Created attachment 323684 [details] Patch
Created attachment 323687 [details] Patch
Created attachment 323689 [details] Patch
Created attachment 323694 [details] Patch
Created attachment 323699 [details] Patch
Created attachment 323706 [details] Patch
Created attachment 323715 [details] Patch
Created attachment 323739 [details] Patch
Comment on attachment 323739 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=323739&action=review > Source/WebCore/platform/mediastream/mac/RealtimeIncomingAudioSourceCocoa.cpp:61 > + Double line
Created attachment 323892 [details] Patch for landing
Comment on attachment 323892 [details] Patch for landing Rejecting attachment 323892 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 323892, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: .webkit.org/git/WebKit b9f4d12..9032476 master -> origin/master Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ... Currently at 223389 = b9f4d12279749dd6113b170a020ca3bd5ea37fe0 r223406 = 9032476984cacdd3aaf521d9babf7105e2c5f8c3 Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Full output: http://webkit-queues.webkit.org/results/4871101
Created attachment 323898 [details] Patch for landing
Comment on attachment 323898 [details] Patch for landing Clearing flags on attachment: 323898 Committed r223412: <https://trac.webkit.org/changeset/223412>
All reviewed patches have been landed. Closing bug.
<rdar://problem/35007894>