Bug 177882

Summary: Teach TextDecorationPainter about pseudo styles
Product: WebKit Reporter: Daniel Bates <dbates>
Component: TextAssignee: Daniel Bates <dbates>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, mmaxfield, sam, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 175784    
Attachments:
Description Flags
Patch simon.fraser: review+

Daniel Bates
Reported 2017-10-04 10:27:37 PDT
Teach TextDecorationPainter about pseudo styles.
Attachments
Patch (7.77 KB, patch)
2017-10-04 10:31 PDT, Daniel Bates 		simon.fraser: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Daniel Bates
Comment 1 2017-10-04 10:31:31 PDT
Created attachment 322686 [details] Patch
Build Bot
Comment 2 2017-10-04 10:34:53 PDT
Attachment 322686 [details] did not pass style-queue: ERROR: Source/WebCore/rendering/TextDecorationPainter.cpp:246: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Sam Weinig
Comment 3 2017-10-04 10:37:30 PDT
Can this be tested?
Daniel Bates
Comment 4 2017-10-04 11:33:50 PDT
(In reply to Sam Weinig from comment #3) > Can this be tested? Not at this time. I will add testing for this code when I make use of it as part of the patch for bug #175784.
Daniel Bates
Comment 5 2017-10-04 11:34:55 PDT
(In reply to Daniel Bates from comment #4) > (In reply to Sam Weinig from comment #3) > > Can this be tested? > > Not at this time. I will add testing for this code when I make use of it as > part of the patch for bug #175784. What I meant to say: It does not seem practical at this time to test this functionality. I plan to add testing for this code when I make use of it as part of the patch for bug #175784.
Daniel Bates
Comment 6 2017-10-04 11:55:23 PDT
Committed r222864: <http://trac.webkit.org/changeset/222864>
Radar WebKit Bug Importer
Comment 7 2017-10-04 11:56:47 PDT
<rdar://problem/34817068>
Note You need to log in before you can comment on or make changes to this bug.