Bug 177843

Summary: Modernize WebKit's back forward list code
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: berto, buildbot, cgarcia, darin, gustavo, mcatanzaro, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 182409    
Attachments:
Description Flags
Patch
none
Patch thorton: review+

Alex Christensen
Reported 2017-10-03 15:10:27 PDT
Moderize WebKit's back forward list code
Attachments
Patch (24.90 KB, patch)
2017-10-03 15:13 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (29.11 KB, patch)
2017-10-03 15:19 PDT, Alex Christensen 		thorton: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2017-10-03 15:13:05 PDT
Created attachment 322590 [details] Patch
Alex Christensen
Comment 2 2017-10-03 15:19:43 PDT
Created attachment 322592 [details] Patch
Build Bot
Comment 3 2017-10-03 15:20:48 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Tim Horton
Comment 4 2017-10-03 15:24:41 PDT
Comment on attachment 322592 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=322592&action=review > Source/WebKit/UIProcess/WebBackForwardList.cpp:-76 > - ASSERT(m_entries[i]); Did you dig into the reasoning behind this? Seems likely it's not just here for fun, no?
Alex Christensen
Comment 5 2017-10-03 15:31:29 PDT
It's now not needed. m_entries[i] used to be a RefPtr and now it's a Ref
Alex Christensen
Comment 6 2017-10-03 15:32:01 PDT
In fact, it doesn't compile any more.
Tim Horton
Comment 7 2017-10-03 16:15:42 PDT
Ah!
Alex Christensen
Comment 8 2017-10-03 17:51:38 PDT
http://trac.webkit.org/r222824
Radar WebKit Bug Importer
Comment 9 2017-10-03 17:52:00 PDT
<rdar://problem/34803896>
Note You need to log in before you can comment on or make changes to this bug.