Bug 177843

Summary:

Modernize WebKit's back forward list code

Product:

WebKit

Reporter:

Alex Christensen <achristensen>

Component:

New Bugs

Assignee:

Alex Christensen <achristensen>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

berto, buildbot, cgarcia, darin, gustavo, mcatanzaro, thorton, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

182409

Attachments:

Description	Flags
Patch	none
Patch	thorton: review+

Description Alex Christensen 2017-10-03 15:10:27 PDT

Moderize WebKit's back forward list code

Comment 1 Alex Christensen 2017-10-03 15:13:05 PDT

Created attachment 322590 [details]
Patch

Comment 2 Alex Christensen 2017-10-03 15:19:43 PDT

Created attachment 322592 [details]
Patch

Comment 3 Build Bot 2017-10-03 15:20:48 PDT

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

Comment 4 Tim Horton 2017-10-03 15:24:41 PDT

Comment on attachment 322592 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=322592&action=review

> Source/WebKit/UIProcess/WebBackForwardList.cpp:-76
> -            ASSERT(m_entries[i]);

Did you dig into the reasoning behind this? Seems likely it's not just here for fun, no?

Comment 5 Alex Christensen 2017-10-03 15:31:29 PDT

It's now not needed.  m_entries[i] used to be a RefPtr and now it's a Ref

Comment 6 Alex Christensen 2017-10-03 15:32:01 PDT

In fact, it doesn't compile any more.

Comment 7 Tim Horton 2017-10-03 16:15:42 PDT

Ah!

Comment 8 Alex Christensen 2017-10-03 17:51:38 PDT

http://trac.webkit.org/r222824

Comment 9 Radar WebKit Bug Importer 2017-10-03 17:52:00 PDT

<rdar://problem/34803896>