Bug 17783

Summary:

Correct USE macros from CF to CFNETWORK

Product:

WebKit

Reporter:

Brent Fulgham <bfulgham>

Component:

WebCore Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

523.x (Safari 3)

Hardware:

OS:

OS X 10.5

Bug Depends on:

Bug Blocks:

17730

Attachments:

Description	Flags
Patch to conditionalize based on CFNetwork	aroben: review+
Small revision to extend ChangeLog.	aroben: review+

Brent Fulgham

Reported 2008-03-11 15:03:10 PDT

There are a handful of places where the use of CFNetwork-specific calls are protected by USE(CF). For now, the Windows (Curl) build still uses CoreFoundation, so it would be nice if these were properly conditionalized. The attached patch is based on changes http://bugs.webkit.org/show_bug.cgi?id=17730

Attachments
Patch to conditionalize based on CFNetwork (3.94 KB, patch) 2008-03-11 16:05 PDT, Brent Fulgham	aroben: review+	Details Formatted Diff Diff
Small revision to extend ChangeLog. (3.55 KB, patch) 2008-03-11 16:22 PDT, Brent Fulgham	aroben: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Brent Fulgham

Comment 1 2008-03-11 16:05:15 PDT

Created attachment 19681 [details] Patch to conditionalize based on CFNetwork The attached patch: * Uses "USE(CFNETWORK)" instead of "PLATFORM(CF)" where appropriate. * Fixes a bug in the call to InternetGetCookie, which was previously passing in the new blank UChar vector, rather than the name of the cookie to retrieve.

Adam Roben (:aroben)

Comment 2 2008-03-11 16:10:35 PDT

Comment on attachment 19681 [details] Patch to conditionalize based on CFNetwork You should add a summary of the changes to the ChangeLog. Something like "Compilation fixes when using CoreFoundation but not CFNetwork". r=me, though the ResourceHandle.h change seems out of place in this patch.

Brent Fulgham

Comment 3 2008-03-11 16:22:16 PDT

Created attachment 19685 [details] Small revision to extend ChangeLog. * Updated Changelog to reference bug and explain change. * Removed "ResourceHandle.h" change. This will be landed in a future patch.

Adam Roben (:aroben)

Comment 4 2008-03-11 16:23:42 PDT

Comment on attachment 19685 [details] Small revision to extend ChangeLog. r=me

Matt Lilek

Comment 5 2008-03-11 16:34:29 PDT

Committed revision 30972.

Note You need to log in before you can comment on or make changes to this bug.