Bug 177798

Summary:

[FETCH] Remove Request.type getter

Product:

WebKit

Reporter:

Dominic Farolino <domfarolino>

Component:

DOM

Assignee:

youenn fablet <youennf>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, cdumez, commit-queue, dbates, esprehn+autocc, japhet, kondapallykalyan, rniwa, webkit-bug-importer, youennf

Priority:

Keywords:

InRadar

Version:

Safari 10

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews104 for mac-elcapitan-wk2	none
Archive of layout-test-results from ews101 for mac-elcapitan	none
Patch	none
Patch for landing	none

Dominic Farolino

Reported 2017-10-02 19:38:12 PDT

As per https://github.com/whatwg/fetch/pull/582 the Request.type getter no longer exists and should be removed. A historical web-platform-test is in the process of being added to assert the non-existence of this attribute (https://github.com/w3c/web-platform-tests/pull/7549).

Attachments
Patch (34.07 KB, patch) 2017-10-10 11:54 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews104 for mac-elcapitan-wk2 (2.22 MB, application/zip) 2017-10-10 13:02 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews101 for mac-elcapitan (1.37 MB, application/zip) 2017-10-10 13:03 PDT, Build Bot	no flags	Details
Patch (41.70 KB, patch) 2017-10-10 13:11 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Patch for landing (20.78 KB, patch) 2017-10-16 13:28 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

youenn fablet

Comment 1 2017-10-10 11:54:08 PDT

Created attachment 323329 [details] Patch

Build Bot

Comment 2 2017-10-10 13:02:18 PDT

Comment on attachment 323329 [details] Patch Attachment 323329 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/4815179 New failing tests: imported/w3c/web-platform-tests/fetch/api/basic/integrity-worker.html imported/w3c/web-platform-tests/fetch/api/request/request-headers.html imported/w3c/web-platform-tests/fetch/api/basic/integrity.html imported/w3c/web-platform-tests/fetch/api/headers/headers-combine.html imported/w3c/web-platform-tests/fetch/api/request/request-error.html imported/w3c/web-platform-tests/fetch/api/request/request-idl.html imported/w3c/web-platform-tests/fetch/api/request/request-structure.html imported/w3c/web-platform-tests/fetch/api/response/response-init-001.html

Build Bot

Comment 3 2017-10-10 13:02:19 PDT

Created attachment 323334 [details] Archive of layout-test-results from ews104 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6

Build Bot

Comment 4 2017-10-10 13:03:35 PDT

Comment on attachment 323329 [details] Patch Attachment 323329 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/4815199 New failing tests: imported/w3c/web-platform-tests/fetch/api/basic/integrity-worker.html imported/w3c/web-platform-tests/fetch/api/request/request-headers.html imported/w3c/web-platform-tests/fetch/api/basic/integrity.html imported/w3c/web-platform-tests/fetch/api/headers/headers-combine.html imported/w3c/web-platform-tests/fetch/api/request/request-error.html imported/w3c/web-platform-tests/fetch/api/request/request-idl.html imported/w3c/web-platform-tests/fetch/api/request/request-structure.html imported/w3c/web-platform-tests/fetch/api/response/response-init-001.html

Build Bot

Comment 5 2017-10-10 13:03:36 PDT

Created attachment 323335 [details] Archive of layout-test-results from ews101 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-elcapitan Platform: Mac OS X 10.11.6

youenn fablet

Comment 6 2017-10-10 13:11:22 PDT

Created attachment 323337 [details] Patch

Chris Dumez

Comment 7 2017-10-16 12:31:17 PDT

Comment on attachment 323337 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=323337&action=review r=me with comments. > Source/WebCore/loader/FetchOptions.h:36 > + I think this is too many blank lines :) > LayoutTests/imported/w3c/ChangeLog:8 > + Refreshing fetch WPT tests. indentation problem.

youenn fablet

Comment 8 2017-10-16 13:28:17 PDT

Created attachment 323934 [details] Patch for landing

WebKit Commit Bot

Comment 9 2017-10-16 14:57:30 PDT

Comment on attachment 323934 [details] Patch for landing Clearing flags on attachment: 323934 Committed r223441: <https://trac.webkit.org/changeset/223441>

WebKit Commit Bot

Comment 10 2017-10-16 14:57:32 PDT

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 11 2017-10-16 14:58:28 PDT

<rdar://problem/35015921>

Note You need to log in before you can comment on or make changes to this bug.