Bug 177796 – Break out new touch debugging code into separate file

• Component: New Bugs
• Status: RESOLVED FIXED

[Megan Gardner]

Break out new touch debugging code into seperate file

[Megan Gardner]

Created attachment 322477 [details]
Patch

[Build Bot]

Attachment 322477 [details] did not pass style-queue:


ERROR: Tools/WebKitTestRunner/ios/HIDDebugTouchWindow.mm:47:  No space between ^ and block definition.  [whitespace/brackets] [4]
ERROR: Tools/WebKitTestRunner/ios/HIDDebugTouchWindow.mm:88:  No space between ^ and block definition.  [whitespace/brackets] [4]
Total errors found: 2 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Tim Horton]

Comment on attachment 322477 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=322477&action=review

> Tools/WebKitTestRunner/ios/HIDDebugTouchWindow.mm:45
> +    static dispatch_once_t onceToken = 0;

Statics don't need to be initialized to 0, it happens magically!

[Megan Gardner]

Created attachment 322483 [details]
Patch

[Build Bot]

Attachment 322483 [details] did not pass style-queue:


ERROR: Tools/WebKitTestRunner/ios/HIDDebugTouchWindow.mm:47:  No space between ^ and block definition.  [whitespace/brackets] [4]
ERROR: Tools/WebKitTestRunner/ios/HIDDebugTouchWindow.mm:88:  No space between ^ and block definition.  [whitespace/brackets] [4]
Total errors found: 2 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Simon Fraser (smfr)]

Comment on attachment 322483 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=322483&action=review

> Tools/WebKitTestRunner/ios/HIDDebugTouchWindow.mm:41
> +@implementation HIDDebugTouchWindow

I think this would read better as GeneratedTouchesDebugWindow or something (the HID isn't really interesting and may change).

> Tools/WebKitTestRunner/ios/HIDDebugTouchWindow.mm:61
> +- (instancetype)init
> +{
> +    self = [super init];
> +    if (!self)
> +        return nil;
> +    
> +    return self;
> +}

This doesn't nothing; you can remove it.

> Tools/WebKitTestRunner/ios/HIDDebugTouchWindow.mm:89
> +        UIApplicationRotationFollowingWindow *touchWindow = [[UIApplicationRotationFollowingWindow alloc] init];

Leak, and you overwrite it 2 lines down.

> Tools/WebKitTestRunner/ios/HIDDebugTouchWindow.mm:90
> +        UIApplicationRotationFollowingControllerNoTouches *viewController = [[UIApplicationRotationFollowingControllerNoTouches alloc] init];

Leak

> Tools/WebKitTestRunner/ios/HIDDebugTouchWindow.mm:91
> +        touchWindow = [[UIApplicationRotationFollowingWindow alloc] init];

Leak

> Tools/WebKitTestRunner/ios/HIDDebugTouchWindow.mm:105
> +            [newView setBackgroundColor:[UIColor colorWithRed:1.0-i*.05 green:0.0 blue:1.0-i*.05 alpha:0.5]];

Spaces around operators please.

[Megan Gardner]

Created attachment 322548 [details]
Patch

[Build Bot]

Attachment 322548 [details] did not pass style-queue:


ERROR: Tools/WebKitTestRunner/ios/GeneratedTouchesDebugWindow.mm:47:  No space between ^ and block definition.  [whitespace/brackets] [4]
ERROR: Tools/WebKitTestRunner/ios/GeneratedTouchesDebugWindow.mm:78:  No space between ^ and block definition.  [whitespace/brackets] [4]
Total errors found: 2 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Build Bot]

Comment on attachment 322548 [details]
Patch

Attachment 322548 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/4746967

New failing tests:
workers/wasm-long-compile.html

[Build Bot]

Created attachment 322617 [details]
Archive of layout-test-results from ews112 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Simon Fraser (smfr)]

Comment on attachment 322548 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=322548&action=review

> Tools/WebKitTestRunner/ios/GeneratedTouchesDebugWindow.mm:34
> +static const NSUInteger debugTouchDotRadius = 5;
> +static const NSUInteger debugTouchDotSize = debugTouchDotRadius * 2;

These should be CGFloats

> Tools/WebKitTestRunner/ios/GeneratedTouchesDebugWindow.mm:98
> +        self.debugTouchViews = [NSArray arrayWithArray:debugViews];

Dunno if it's worth the copy just to make it non-mutable.

[Megan Gardner]

https://trac.webkit.org/changeset/222890/webkit

[Radar WebKit Bug Importer]

<rdar://problem/36489065>