| Summary: | A JSFunction's ObjectAllocationProfile should watch the poly prototype watchpoint so it can clear its object allocation profile | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Saam Barati <saam> | ||||||
| Component: | JavaScriptCore | Assignee: | Saam Barati <saam> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | benjamin, commit-queue, fpizlo, ggaren, gskachkov, jfbastien, keith_miller, mark.lam, msaboff, rmorisset, ticaiolima, webkit-bug-importer, ysuzuki | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Saam Barati
2017-10-02 16:11:49 PDT
patch forthcoming Created attachment 323373 [details]
patch
Comment on attachment 323373 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=323373&action=review r=me > Source/JavaScriptCore/runtime/FunctionRareData.h:114 > + class ClearAllocationProfile : public Watchpoint { How about naming it ClearAllocationProfileWatchpoint? Thanks for the review. I forgot about this patch. Will land it today with your naming suggestion. Comment on attachment 323373 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=323373&action=review >> Source/JavaScriptCore/runtime/FunctionRareData.h:114 >> + class ClearAllocationProfile : public Watchpoint { > > How about naming it ClearAllocationProfileWatchpoint? I'm actually thinking that "AllocationProfileClearingWatchpoint" is a better name and more in line with our other names, like, StructureStubInfoClearingWatchpoint. Created attachment 326372 [details]
patch for landing
Comment on attachment 326372 [details] patch for landing Clearing flags on attachment: 326372 Committed r224603: <https://trac.webkit.org/changeset/224603> All reviewed patches have been landed. Closing bug. Comment on attachment 323373 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=323373&action=review >>> Source/JavaScriptCore/runtime/FunctionRareData.h:114 >>> + class ClearAllocationProfile : public Watchpoint { >> >> How about naming it ClearAllocationProfileWatchpoint? > > I'm actually thinking that "AllocationProfileClearingWatchpoint" is a better name and more in line with our other names, like, StructureStubInfoClearingWatchpoint. That sounds nice! |