| Summary: | VMTraps shouldn't crash if it sees an exception it doesn't understand. | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Keith Miller <keith_miller> | ||||||||
| Component: | New Bugs | Assignee: | Keith Miller <keith_miller> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | buildbot, commit-queue, mark.lam, msaboff, saam, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Keith Miller
2017-10-02 14:39:35 PDT
Created attachment 322444 [details]
Patch
Comment on attachment 322444 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=322444&action=review r=me with fixes. Would you happen to have a test for this already? > Source/JavaScriptCore/ChangeLog:11 > + noting that this means there's no way to know if, due a bug, we due *to* a bug. > Source/JavaScriptCore/runtime/VMTraps.cpp:216 > + return SignalAction::HotHandled; /HotHandled/NotHandled/. Created attachment 322445 [details]
Patch for landing
Created attachment 322446 [details]
Patch for landing
Comment on attachment 322445 [details] Patch for landing View in context: https://bugs.webkit.org/attachment.cgi?id=322445&action=review > Source/JavaScriptCore/ChangeLog:11 > + noting that this means there's no way to know if, due a bug, we typo still here. (In reply to Mark Lam from comment #2) > Comment on attachment 322444 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=322444&action=review > > r=me with fixes. Would you happen to have a test for this already? > I do but it's adding watchdog testing to JSTests/wasm.yaml. Unfortunately, that causes other crashes so I'll land that testing in a follow up. Committed r222748: <http://trac.webkit.org/changeset/222748> |