Bug 177778

Summary: PasteImage tests are failing on debug builds
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: New BugsAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, jlewis3, ryanhaddad, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Fixes the bug
none
Patch for landing none

Ryosuke Niwa
Reported 2017-10-02 13:57:41 PDT
PasteImage tests are failing on debug builds
Attachments
Fixes the bug (4.90 KB, patch)
2017-10-02 13:59 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Patch for landing (3.21 KB, patch)
2017-10-02 14:39 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2017-10-02 13:59:56 PDT
Created attachment 322433 [details] Fixes the bug
Wenson Hsieh
Comment 2 2017-10-02 14:08:17 PDT
Comment on attachment 322433 [details] Fixes the bug View in context: https://bugs.webkit.org/attachment.cgi?id=322433&action=review > Source/WebCore/ChangeLog:8 > + After r222702, we're not supposed to be adding "Files" as types. Removed the code to do this I think it'd be more accurate to say "...PlatformPasteboard is no longer responsible for adding "Files" as a type..." here, since "Files" is still added as a type, it's just that DataTransfer takes care of it now. > Tools/TestWebKitAPI/Tests/ios/DataInteractionTests.mm:1036 > +#if __IPHONE_OS_VERSION_MIN_REQUIRED >= 110300 I think we'll also need to define out a couple of static helpers above that will no longer be used on iOS 11.0, otherwise the build will complain about unused code. I can take care of this in a separate change (as test gardening).
Wenson Hsieh
Comment 3 2017-10-02 14:36:26 PDT
(In reply to Wenson Hsieh from comment #2) > Comment on attachment 322433 [details] > Fixes the bug > > View in context: > https://bugs.webkit.org/attachment.cgi?id=322433&action=review > > > Source/WebCore/ChangeLog:8 > > + After r222702, we're not supposed to be adding "Files" as types. Removed the code to do this > > I think it'd be more accurate to say "...PlatformPasteboard is no longer > responsible for adding "Files" as a type..." here, since "Files" is still > added as a type, it's just that DataTransfer takes care of it now. > > > Tools/TestWebKitAPI/Tests/ios/DataInteractionTests.mm:1036 > > +#if __IPHONE_OS_VERSION_MIN_REQUIRED >= 110300 > > I think we'll also need to define out a couple of static helpers above that > will no longer be used on iOS 11.0, otherwise the build will complain about > unused code. I can take care of this in a separate change (as test > gardening). Landed in https://trac.webkit.org/changeset/222743/webkit.
Ryosuke Niwa
Comment 4 2017-10-02 14:39:57 PDT
Created attachment 322442 [details] Patch for landing
Ryosuke Niwa
Comment 5 2017-10-02 14:44:08 PDT
Comment on attachment 322442 [details] Patch for landing Clearing flags on attachment: 322442 Committed r222746: <http://trac.webkit.org/changeset/222746>
Ryosuke Niwa
Comment 6 2017-10-02 14:44:10 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2017-10-02 14:45:35 PDT
<rdar://problem/34777058>
Note You need to log in before you can comment on or make changes to this bug.