Bug 177774

Summary: Web Inspector: After enabling the new Network Tab in experimental settings, the network tab disappears
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, hi, inspector-bugzilla-changes, joepeck, mjs, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Proposed Fix
none
[PATCH] Proposed Fix none

Joseph Pecoraro
Reported 2017-10-02 13:45:54 PDT
After enabling the new Network Tab in experimental settings, the network tab disappears. Steps to reproduce: 1. Open Web Inspector 2. Click the gear for settings 3. Click Experimental 4. Check New Network Tab 5. Reload the inspector with the button that appears Result: Network Tab disappears. Expected: Network Tab to be there just different. Note: It is possible to add it back with New Tab however.
Attachments
[PATCH] Proposed Fix (2.53 KB, patch)
2017-10-02 13:47 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
[PATCH] Proposed Fix (2.67 KB, patch)
2017-10-03 18:03 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1 2017-10-02 13:46:02 PDT
<rdar://problem/34771647>
Joseph Pecoraro
Comment 2 2017-10-02 13:47:03 PDT
Created attachment 322425 [details] [PATCH] Proposed Fix
Devin Rousso
Comment 3 2017-10-02 17:00:03 PDT
Comment on attachment 322425 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=322425&action=review > Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js:259 > + if (!WI.settings.experimentalEnableNewNetworkTab.value) Shouldn't the reverse also be done (replace WI.NetworkTabContentView with WI.LEgacyNetworkTabContentView) if the setting changes to off? Also, doesn't a warning appear when you toggle this setting that you have to refresh to see the effects? Maybe a better solution would be to force a refresh if the user switches off the settings tab without clicking that button :|
Joseph Pecoraro
Comment 4 2017-10-02 17:41:23 PDT
Comment on attachment 322425 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=322425&action=review >> Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js:259 >> + if (!WI.settings.experimentalEnableNewNetworkTab.value) > > Shouldn't the reverse also be done (replace WI.NetworkTabContentView with WI.LEgacyNetworkTabContentView) if the setting changes to off? Also, doesn't a warning appear when you toggle this setting that you have to refresh to see the effects? Maybe a better solution would be to force a refresh if the user switches off the settings tab without clicking that button :| Sure I can do this for the legacy direction.
Joseph Pecoraro
Comment 5 2017-10-03 18:03:26 PDT
Created attachment 322622 [details] [PATCH] Proposed Fix
Devin Rousso
Comment 6 2017-10-03 18:30:28 PDT
Comment on attachment 322622 [details] [PATCH] Proposed Fix r=me
WebKit Commit Bot
Comment 7 2017-10-04 11:30:41 PDT
Comment on attachment 322622 [details] [PATCH] Proposed Fix Clearing flags on attachment: 322622 Committed r222860: <http://trac.webkit.org/changeset/222860>
WebKit Commit Bot
Comment 8 2017-10-04 11:30:42 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.