Bug 177774

Summary:

Web Inspector: After enabling the new Network Tab in experimental settings, the network tab disappears

Product:

WebKit

Reporter:

Joseph Pecoraro <joepeck>

Component:

Web Inspector

Assignee:

Joseph Pecoraro <joepeck>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, hi, inspector-bugzilla-changes, joepeck, mjs, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
[PATCH] Proposed Fix	none
[PATCH] Proposed Fix	none

Description Joseph Pecoraro 2017-10-02 13:45:54 PDT

After enabling the new Network Tab in experimental settings, the network tab disappears.

Steps to reproduce:
1. Open Web Inspector
2. Click the gear for settings
3. Click Experimental
4. Check New Network Tab
5. Reload the inspector with the button that appears

Result:
Network Tab disappears.

Expected:
Network Tab to be there just different.

Note:
It is possible to add it back with New Tab however.

Comment 1 Joseph Pecoraro 2017-10-02 13:46:02 PDT

<rdar://problem/34771647>

Comment 2 Joseph Pecoraro 2017-10-02 13:47:03 PDT

Created attachment 322425 [details]
[PATCH] Proposed Fix

Comment 3 Devin Rousso 2017-10-02 17:00:03 PDT

Comment on attachment 322425 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=322425&action=review

> Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js:259
> +                if (!WI.settings.experimentalEnableNewNetworkTab.value)

Shouldn't the reverse also be done (replace WI.NetworkTabContentView with WI.LEgacyNetworkTabContentView) if the setting changes to off?  Also, doesn't a warning appear when you toggle this setting that you have to refresh to see the effects?  Maybe a better solution would be to force a refresh if the user switches off the settings tab without clicking that button :|

Comment 4 Joseph Pecoraro 2017-10-02 17:41:23 PDT

Comment on attachment 322425 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=322425&action=review

>> Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js:259
>> +                if (!WI.settings.experimentalEnableNewNetworkTab.value)
> 
> Shouldn't the reverse also be done (replace WI.NetworkTabContentView with WI.LEgacyNetworkTabContentView) if the setting changes to off?  Also, doesn't a warning appear when you toggle this setting that you have to refresh to see the effects?  Maybe a better solution would be to force a refresh if the user switches off the settings tab without clicking that button :|

Sure I can do this for the legacy direction.

Comment 5 Joseph Pecoraro 2017-10-03 18:03:26 PDT

Created attachment 322622 [details]
[PATCH] Proposed Fix

Comment 6 Devin Rousso 2017-10-03 18:30:28 PDT

Comment on attachment 322622 [details]
[PATCH] Proposed Fix

r=me

Comment 7 WebKit Commit Bot 2017-10-04 11:30:41 PDT

Comment on attachment 322622 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 322622

Committed r222860: <http://trac.webkit.org/changeset/222860>

Comment 8 WebKit Commit Bot 2017-10-04 11:30:42 PDT

All reviewed patches have been landed.  Closing bug.