Bug 177763

Summary:

AX: [ATK] ARIA drag-and-drop attribute values should be exposed via AtkObject attributes

Product:

WebKit

Reporter:

Joanmarie Diggs <jdiggs>

Component:

Accessibility

Assignee:

Joanmarie Diggs <jdiggs>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aboxhall, apinheiro, buildbot, cfleizach, commit-queue, dmazzoni, jcraig, rniwa, samuel_white, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

Linux

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Archive of layout-test-results from ews106 for mac-elcapitan-wk2	none

Joanmarie Diggs

Reported 2017-10-02 12:01:10 PDT

The values of aria-grabbed and aria-dropeffect are not exposed via ATK. The Core AAM states they should be exposed via AtkObject attributes.

Attachments
Patch (6.01 KB, patch) 2017-10-02 12:04 PDT, Joanmarie Diggs	no flags	Details Formatted Diff Diff
Patch (7.26 KB, patch) 2017-10-02 23:45 PDT, Joanmarie Diggs	no flags	Details Formatted Diff Diff
Patch (7.97 KB, patch) 2017-10-03 00:21 PDT, Joanmarie Diggs	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews106 for mac-elcapitan-wk2 (1.78 MB, application/zip) 2017-10-03 04:35 PDT, Build Bot	no flags	Details
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2017-10-02 12:01:49 PDT

<rdar://problem/34772635>

Joanmarie Diggs

Comment 2 2017-10-02 12:04:55 PDT

Created attachment 322407 [details] Patch

Joanmarie Diggs

Comment 3 2017-10-02 23:45:27 PDT

Created attachment 322494 [details] Patch

chris fleizach

Comment 4 2017-10-02 23:53:15 PDT

Comment on attachment 322494 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=322494&action=review > Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp:586 > + attributeSet = addToAtkAttributeSet(attributeSet, "grabbed", "false"); is this bit tested? doesn't look like there's a WTR method for checking aria dragging presence

Joanmarie Diggs

Comment 5 2017-10-03 00:03:14 PDT

Comment on attachment 322494 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=322494&action=review >> Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp:586 >> + attributeSet = addToAtkAttributeSet(attributeSet, "grabbed", "false"); > > is this bit tested? doesn't look like there's a WTR method for checking aria dragging presence It was tested back when I was just dumping object attributes (before I found the unimplemented WTR methods). I'll add dumping into the revised test. Thanks for catching that!

Joanmarie Diggs

Comment 6 2017-10-03 00:21:45 PDT

Created attachment 322497 [details] Patch

Build Bot

Comment 7 2017-10-03 04:35:42 PDT

Comment on attachment 322497 [details] Patch Attachment 322497 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/4738425 Number of test failures exceeded the failure limit.

Build Bot

Comment 8 2017-10-03 04:35:43 PDT

Created attachment 322508 [details] Archive of layout-test-results from ews106 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6

Joanmarie Diggs

Comment 9 2017-10-03 04:48:17 PDT

Comment on attachment 322497 [details] Patch Resetting cq+. This patch only touches Linux accessibility code. Thus I really cannot imagine it's breaking non-accessibility mac tests. If I'm wrong, please explain what I'm missing.

WebKit Commit Bot

Comment 10 2017-10-03 10:56:53 PDT

Comment on attachment 322497 [details] Patch Clearing flags on attachment: 322497 Committed r222787: <http://trac.webkit.org/changeset/222787>

WebKit Commit Bot

Comment 11 2017-10-03 10:56:55 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.