Bug 177749

Summary: Use InlineTextBox::lineFont() in more places
Product: WebKit Reporter: Daniel Bates <dbates>
Component: Layout and RenderingAssignee: Daniel Bates <dbates>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, buildbot, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews116 for mac-elcapitan none

Daniel Bates
Reported 2017-10-02 09:48:05 PDT
Use InlineTextBox::lineFont() in more places instead of passing it around.
Attachments
Patch (12.93 KB, patch)
2017-10-02 09:55 PDT, Daniel Bates 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews116 for mac-elcapitan (1.82 MB, application/zip)
2017-10-02 11:21 PDT, Build Bot 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Daniel Bates
Comment 1 2017-10-02 09:55:08 PDT
Created attachment 322382 [details] Patch
Build Bot
Comment 2 2017-10-02 11:21:29 PDT
Comment on attachment 322382 [details] Patch Attachment 322382 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/4725608 New failing tests: imported/w3c/web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-tokenization-screenx-screeny.html
Build Bot
Comment 3 2017-10-02 11:21:31 PDT
Created attachment 322396 [details] Archive of layout-test-results from ews116 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews116 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Daniel Bates
Comment 4 2017-10-02 12:24:54 PDT
(In reply to Build Bot from comment #2) > Comment on attachment 322382 [details] > Patch > > Attachment 322382 [details] did not pass mac-debug-ews (mac): > Output: http://webkit-queues.webkit.org/results/4725608 > > New failing tests: > imported/w3c/web-platform-tests/html/browsers/the-window-object/apis-for- > creating-and-navigating-browsing-contexts-by-name/open-features-tokenization- > screenx-screeny.html This failure is unrelated to this patch.
Daniel Bates
Comment 5 2017-10-02 16:44:41 PDT
Comment on attachment 322382 [details] Patch Clearing flags on attachment: 322382 Committed r222758: <http://trac.webkit.org/changeset/222758>
Daniel Bates
Comment 6 2017-10-02 16:44:42 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2017-10-02 16:45:35 PDT
<rdar://problem/34780472>
Note You need to log in before you can comment on or make changes to this bug.