Bug 177742

Summary: [GTK] Do not hardcode font family in served remote inspector HTML snippets
Product: WebKit Reporter: Adrian Perez <aperez>
Component: WebKit Misc.Assignee: Adrian Perez <aperez>
Status: RESOLVED FIXED    
Severity: Normal CC: berto, buildbot, cgarcia, commit-queue, darin, gustavo, mcatanzaro, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Description Adrian Perez 2017-10-02 06:44:04 PDT 
There's a string with a HTML+CSS snippet in
Source/WebKit/UIProcess/API/gtk/WebKitRemoteInspectorProtocolHandler.cpp
which contains a hardcoded font. It seems like it would be a good idea
to not hardcode this.
Comment 1 Adrian Perez 2017-10-02 06:45:55 PDT 
This could be done in a similar way as this patch in Epiphany:

  https://bugzilla.gnome.org/show_bug.cgi?id=783489

It uses “font:menu” to obtain the system font, which is supported
since CSS 2. I'll be sending a patch.
Comment 2 Adrian Perez 2017-10-02 06:49:01 PDT 
Created attachment 322373 [details]
Patch
Comment 3 Build Bot 2017-10-02 06:51:47 PDT 
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 4 Adrian Perez 2017-10-02 14:38:24 PDT 
Created attachment 322441 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2017-10-02 15:01:01 PDT 
Comment on attachment 322441 [details]
Patch for landing

Clearing flags on attachment: 322441

Committed r222749: <http://trac.webkit.org/changeset/222749>
Comment 6 WebKit Commit Bot 2017-10-02 15:01:03 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2017-10-02 15:01:50 PDT 
<rdar://problem/34777611>