Bug 177706

Summary: Add makeWeakPtr for easier WeakPtr construction
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: Web Template FrameworkAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ggaren, jiewen_tan, rniwa, sam, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
sam: review+
patch none

Antti Koivisto
Reported 2017-09-30 01:48:53 PDT
Better WeakPtr construction.
Attachments
patch (8.08 KB, patch)
2017-09-30 02:07 PDT, Antti Koivisto 		sam: review+
DetailsFormatted DiffDiff
patch (7.73 KB, patch)
2017-09-30 04:42 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2017-09-30 02:07:58 PDT
Created attachment 322291 [details] patch
Sam Weinig
Comment 2 2017-09-30 02:16:39 PDT
Comment on attachment 322291 [details] patch r=me. I would separate out the operator bool change, since that will probably require some API test changes.
Antti Koivisto
Comment 3 2017-09-30 04:42:58 PDT
Created attachment 322294 [details] patch
WebKit Commit Bot
Comment 4 2017-09-30 06:44:07 PDT
Comment on attachment 322294 [details] patch Clearing flags on attachment: 322294 Committed r222682: <http://trac.webkit.org/changeset/222682>
WebKit Commit Bot
Comment 5 2017-09-30 06:44:09 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2017-09-30 06:45:30 PDT
<rdar://problem/34755419>
Ryosuke Niwa
Comment 7 2017-09-30 13:11:33 PDT
We can also add variants of makeWeakPtr which takes RefPtr & Ref!
Note You need to log in before you can comment on or make changes to this bug.