Bug 177706

Summary: Add makeWeakPtr for easier WeakPtr construction
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: Web Template FrameworkAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ggaren, jiewen_tan, rniwa, sam, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
sam: review+
patch none

Description Antti Koivisto 2017-09-30 01:48:53 PDT 
Better WeakPtr construction.
Comment 1 Antti Koivisto 2017-09-30 02:07:58 PDT 
Created attachment 322291 [details]
patch
Comment 2 Sam Weinig 2017-09-30 02:16:39 PDT 
Comment on attachment 322291 [details]
patch

r=me. I would separate out the operator bool change, since that will probably require some API test changes.
Comment 3 Antti Koivisto 2017-09-30 04:42:58 PDT 
Created attachment 322294 [details]
patch
Comment 4 WebKit Commit Bot 2017-09-30 06:44:07 PDT 
Comment on attachment 322294 [details]
patch

Clearing flags on attachment: 322294

Committed r222682: <http://trac.webkit.org/changeset/222682>
Comment 5 WebKit Commit Bot 2017-09-30 06:44:09 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2017-09-30 06:45:30 PDT 
<rdar://problem/34755419>
Comment 7 Ryosuke Niwa 2017-09-30 13:11:33 PDT 
We can also add variants of makeWeakPtr which takes RefPtr & Ref!