Bug 177703

Summary: [JSC] Introduce import.meta
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: JavaScriptCoreAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, fpizlo, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch fpizlo: review+

Yusuke Suzuki
Reported 2017-09-29 23:21:36 PDT
import.meta becomes stage 3.
Attachments
Patch (24.03 KB, patch)
2017-09-30 01:22 PDT, Yusuke Suzuki 		fpizlo: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2017-09-30 01:22:11 PDT
Created attachment 322287 [details] Patch
Yusuke Suzuki
Comment 2 2017-10-04 20:12:09 PDT
Ping?
Filip Pizlo
Comment 3 2017-10-04 20:15:29 PDT
Comment on attachment 322287 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=322287&action=review > Source/JavaScriptCore/parser/Parser.cpp:431 > + // They are `import("...")` call or `import.meta` meta property cases. It’s still “this is”. This is one thing, which we choose from two things. Therefore, singular.
Yusuke Suzuki
Comment 4 2017-10-04 20:53:46 PDT
Comment on attachment 322287 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=322287&action=review >> Source/JavaScriptCore/parser/Parser.cpp:431 >> + // They are `import("...")` call or `import.meta` meta property cases. > > It’s still “this is”. This is one thing, which we choose from two things. Therefore, singular. Oh! Thanks, fixed.
Yusuke Suzuki
Comment 5 2017-10-04 20:57:49 PDT
Committed r222895: <http://trac.webkit.org/changeset/222895>
Radar WebKit Bug Importer
Comment 6 2017-10-04 20:58:15 PDT
<rdar://problem/34827357>
Saam Barati
Comment 7 2017-10-04 22:15:52 PDT
Comment on attachment 322287 [details] Patch LGTM too
Note You need to log in before you can comment on or make changes to this bug.