Summary: | Expose more WKPreferences SPI to match C SPI | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Alex Christensen <achristensen> | ||||
Component: | New Bugs | Assignee: | Alex Christensen <achristensen> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | darin, mitz, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Alex Christensen
2017-09-29 18:24:45 PDT
Created attachment 322261 [details]
Patch
Comment on attachment 322261 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=322261&action=review > Source/WebKit/UIProcess/API/Cocoa/WKPreferences.mm:669 > +- (BOOL)_javaEnabledForLocalFiles > +{ > + return _preferences->pluginsEnabled(); > +} Is this correct? I’d expect the underlying function to be something about Java for local files. Not only are you correct, but also my SPI version of _plugInsEnabled is not needed because we have public API for that. Will fix. |