Bug 177697

Summary:

Expose more WKPreferences SPI to match C SPI

Product:

WebKit

Reporter:

Alex Christensen <achristensen>

Component:

New Bugs

Assignee:

Alex Christensen <achristensen>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

darin, mitz, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	darin: review+

Alex Christensen

Reported 2017-09-29 18:24:45 PDT

Expose more WKPreferences SPI to match C SPI

Attachments
Patch (14.50 KB, patch) 2017-09-29 18:25 PDT, Alex Christensen	darin: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Alex Christensen

Comment 1 2017-09-29 18:25:20 PDT

Created attachment 322261 [details] Patch

Alex Christensen

Comment 2 2017-10-02 09:50:24 PDT

http://trac.webkit.org/r222711

Radar WebKit Bug Importer

Comment 3 2017-10-02 09:51:30 PDT

<rdar://problem/34768813>

mitz

Comment 4 2017-10-02 09:59:09 PDT

Comment on attachment 322261 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=322261&action=review > Source/WebKit/UIProcess/API/Cocoa/WKPreferences.mm:669 > +- (BOOL)_javaEnabledForLocalFiles > +{ > + return _preferences->pluginsEnabled(); > +} Is this correct? I’d expect the underlying function to be something about Java for local files.

Alex Christensen

Comment 5 2017-10-02 10:02:41 PDT

Not only are you correct, but also my SPI version of _plugInsEnabled is not needed because we have public API for that. Will fix.

Alex Christensen

Comment 6 2017-10-02 10:13:34 PDT

http://trac.webkit.org/r222715

Alex Christensen

Comment 7 2017-10-02 10:36:29 PDT

https://trac.webkit.org/changeset/222718/webkit

Note You need to log in before you can comment on or make changes to this bug.