Bug 177669

Summary: [iOS] Remove unused pre-iOS 11 codepaths for writing to the pasteboard
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: HTML EditingAssignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, megan_gardner, rniwa, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
thorton: review+
Patch for landing none

Wenson Hsieh
Reported 2017-09-29 10:32:42 PDT
This is all just dead code, and can now be safely removed.
Attachments
Patch (11.38 KB, patch)
2017-09-29 10:37 PDT, Wenson Hsieh 		thorton: review+
DetailsFormatted DiffDiff
Patch for landing (11.34 KB, patch)
2017-09-29 11:09 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Wenson Hsieh
Comment 1 2017-09-29 10:37:13 PDT
Created attachment 322198 [details] Patch
Tim Horton
Comment 2 2017-09-29 10:54:11 PDT
Comment on attachment 322198 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=322198&action=review > Source/WebCore/platform/ios/PlatformPasteboardIOS.mm:55 > +#if TARGET_OS_IOS I think we usually don't use the platform target conditionals, and prefer PLATFORM(IOS) && !(PLATFORM(WATCHOS) || PLATFORM(APPLETV)), however sad that may be. If you don't want to say that everywhere, add a thing like ENABLE_DATA_DETECTION or HAVE_AVKIT are defined in Platform.h?
Wenson Hsieh
Comment 3 2017-09-29 11:02:00 PDT
Comment on attachment 322198 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=322198&action=review >> Source/WebCore/platform/ios/PlatformPasteboardIOS.mm:55 >> +#if TARGET_OS_IOS > > I think we usually don't use the platform target conditionals, and prefer PLATFORM(IOS) && !(PLATFORM(WATCHOS) || PLATFORM(APPLETV)), however sad that may be. If you don't want to say that everywhere, add a thing like ENABLE_DATA_DETECTION or HAVE_AVKIT are defined in Platform.h? Oh, I see! That sounds fine then. Since this is a pretty specific HAVE(), I think I'll just use the PLATFORM() macros here. With the exception of the [NSURL _title], these are things we only want to compile if UIPasteboard exposes a list of NSItemProviders, so I'm not sure it'll be very useful elsewhere. But if it is, we can probably figure out a general term to describe this.
Wenson Hsieh
Comment 4 2017-09-29 11:09:15 PDT
Created attachment 322213 [details] Patch for landing
WebKit Commit Bot
Comment 5 2017-09-29 11:53:26 PDT
Comment on attachment 322213 [details] Patch for landing Clearing flags on attachment: 322213 Committed r222659: <http://trac.webkit.org/changeset/222659>
Radar WebKit Bug Importer
Comment 6 2017-09-29 14:38:40 PDT
<rdar://problem/34747803>
Note You need to log in before you can comment on or make changes to this bug.