Bug 177667

Summary: [WK2][NETWORK_SESSION] Move some authentication-related code to avoid duplication
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, commit-queue, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 177625    
Attachments:
Description Flags
Patch
none
Patch none

Description Chris Dumez 2017-09-29 10:16:29 PDT
Move some authentication-related code to avoid duplication.
Comment 1 Chris Dumez 2017-09-29 10:47:58 PDT
Created attachment 322209 [details]
Patch
Comment 2 Alex Christensen 2017-09-29 14:39:02 PDT
Comment on attachment 322209 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=322209&action=review

> Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm:233
> +    if ([challenge.protectionSpace.authenticationMethod isEqualTo:NSURLAuthenticationMethodServerTrust] && !NetworkProcess::singleton().canHandleHTTPSServerTrustEvaluation()) {

isEqualToString
Comment 3 Chris Dumez 2017-09-29 14:47:50 PDT
Created attachment 322237 [details]
Patch
Comment 4 Chris Dumez 2017-09-29 15:08:37 PDT
Comment on attachment 322237 [details]
Patch

Clearing flags on attachment: 322237

Committed r222667: <http://trac.webkit.org/changeset/222667>
Comment 5 Chris Dumez 2017-09-29 15:08:39 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2017-09-29 15:09:43 PDT
<rdar://problem/34748554>