Bug 177662

Summary: [iOS WK2] Implement -[WKContentView hasText] for compatibility with the UITextInput protocol
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: WebKit2Assignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, megan_gardner, rniwa, thorton
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Remove unnecessary UIKit.h import none

Wenson Hsieh
Reported 2017-09-29 09:23:48 PDT
Technically, -hasText is already implemented on WKContentView, but it currently always returns a bogus value of YES. Semantically, -hasText should only be YES if the content being edited is represented by a "non-zero-length string".
Attachments
Patch (19.98 KB, patch)
2017-09-29 10:10 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Remove unnecessary UIKit.h import (20.34 KB, patch)
2017-09-29 10:14 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Wenson Hsieh
Comment 1 2017-09-29 09:24:17 PDT
<rdar://problem/33410373>
Wenson Hsieh
Comment 2 2017-09-29 10:10:14 PDT
Created attachment 322191 [details] Patch
Wenson Hsieh
Comment 3 2017-09-29 10:14:30 PDT
Created attachment 322192 [details] Remove unnecessary UIKit.h import
Wenson Hsieh
Comment 4 2017-09-29 11:02:54 PDT
Comment on attachment 322192 [details] Remove unnecessary UIKit.h import Thanks Tim!
WebKit Commit Bot
Comment 5 2017-09-29 11:33:36 PDT
Comment on attachment 322192 [details] Remove unnecessary UIKit.h import Clearing flags on attachment: 322192 Committed r222654: <http://trac.webkit.org/changeset/222654>
WebKit Commit Bot
Comment 6 2017-09-29 11:33:38 PDT
All reviewed patches have been landed. Closing bug.
Wenson Hsieh
Comment 7 2017-09-30 11:52:26 PDT
It looks like one of the API tests added here is flaky due to a latent bug. Fixing in https://bugs.webkit.org/show_bug.cgi?id=177698
Note You need to log in before you can comment on or make changes to this bug.