Bug 177662

Summary: [iOS WK2] Implement -[WKContentView hasText] for compatibility with the UITextInput protocol
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: WebKit2Assignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, megan_gardner, rniwa, thorton
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Remove unnecessary UIKit.h import none

Description Wenson Hsieh 2017-09-29 09:23:48 PDT 
Technically, -hasText is already implemented on WKContentView, but it currently always returns a bogus value of YES. Semantically, -hasText should only be YES if the content being edited is represented by a "non-zero-length string".
Comment 1 Wenson Hsieh 2017-09-29 09:24:17 PDT 
<rdar://problem/33410373>
Comment 2 Wenson Hsieh 2017-09-29 10:10:14 PDT 
Created attachment 322191 [details]
Patch
Comment 3 Wenson Hsieh 2017-09-29 10:14:30 PDT 
Created attachment 322192 [details]
Remove unnecessary UIKit.h import
Comment 4 Wenson Hsieh 2017-09-29 11:02:54 PDT 
Comment on attachment 322192 [details]
Remove unnecessary UIKit.h import

Thanks Tim!
Comment 5 WebKit Commit Bot 2017-09-29 11:33:36 PDT 
Comment on attachment 322192 [details]
Remove unnecessary UIKit.h import

Clearing flags on attachment: 322192

Committed r222654: <http://trac.webkit.org/changeset/222654>
Comment 6 WebKit Commit Bot 2017-09-29 11:33:38 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Wenson Hsieh 2017-09-30 11:52:26 PDT 
It looks like one of the API tests added here is flaky due to a latent bug. Fixing in https://bugs.webkit.org/show_bug.cgi?id=177698