Bug 177654

Summary: Add a WebKit Build Archives page
Product: WebKit Reporter: Jon Davis <jond>
Component: WebKit WebsiteAssignee: Jon Davis <jond>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, commit-queue, jond, lforschler, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Jon Davis
Reported 2017-09-29 07:49:44 PDT
Add a page to provide downloads to WebKit Build Archives.
Attachments
Patch (9.76 KB, patch)
2017-09-29 08:02 PDT, Jon Davis
no flags
Patch (10.65 KB, patch)
2017-10-02 08:23 PDT, Jon Davis
no flags
Jon Davis
Comment 1 2017-09-29 08:02:08 PDT
Alexey Proskuryakov
Comment 2 2017-09-29 15:00:54 PDT
Comment on attachment 322184 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=322184&action=review > Websites/webkit.org/ChangeLog:13 > +2017-09-29 Jon Davis <jond@apple.com> > + > + Add a WebKit Build Archives page > + https://bugs.webkit.org/show_bug.cgi?id=177654 Duplicate ChangeLog. > Websites/webkit.org/wp-content/themes/webkit/build-archives.php:31 > + if ( is_wp_error($response) ) Coding style: spaces. > Websites/webkit.org/wp-content/themes/webkit/build-archives.php:69 > + var date = new Date(parseInt(timestamp.innerHTML)); Can we use textContent here? > Websites/webkit.org/wp-content/themes/webkit/build-archives.php:70 > + timestamp.innerHTML = date.toLocaleDateString('en', {"timeZoneName":"short","minute":"2-digit","hour":"2-digit","day":"numeric","month":"long","year":"numeric"}) Ditto. Also, can you fix the mix of double and single quotes throughout? > Websites/webkit.org/wp-content/themes/webkit/build-archives.php:77 > + if ( currentLink.length ) Coding style. > Websites/webkit.org/wp-content/themes/webkit/build-archives.php:83 > + if ( currentList.length ) Coding style. > Websites/webkit.org/wp-content/themes/webkit/build-archives.php:92 > + if (link.className.indexOf(window.location.hash.replace('#','')) !== -1) Coding style: space after comma. > Websites/webkit.org/wp-content/themes/webkit/build-archives.php:103 > + echo '<meta name="robots" content="nofollow" />'; Please don't use XML self-closing syntax in HTML
Jon Davis
Comment 3 2017-10-02 08:23:09 PDT
WebKit Commit Bot
Comment 4 2017-10-02 10:26:41 PDT
Comment on attachment 322377 [details] Patch Clearing flags on attachment: 322377 Committed r222717: <http://trac.webkit.org/changeset/222717>
WebKit Commit Bot
Comment 5 2017-10-02 10:26:42 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2017-10-02 10:27:49 PDT
Note You need to log in before you can comment on or make changes to this bug.