Bug 177637

Summary: Re-enable more pasteboard tests on iOS after r222595
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: Tools / TestsAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, buildbot, lforschler, ryanhaddad, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Re-enables tests
none
Archive of layout-test-results from ews123 for ios-simulator-wk2
none
Patch none

Ryosuke Niwa
Reported 2017-09-28 19:43:39 PDT
Re-enable more pasteboard tests on iOS after r222595
Attachments
Re-enables tests (2.78 KB, patch)
2017-09-28 19:44 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews123 for ios-simulator-wk2 (964.80 KB, application/zip)
2017-09-28 21:15 PDT, Build Bot 		no flags
Details
Patch (1.88 KB, patch)
2017-09-28 22:47 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2017-09-28 19:44:33 PDT
Created attachment 322156 [details] Re-enables tests
Build Bot
Comment 2 2017-09-28 21:15:11 PDT
Comment on attachment 322156 [details] Re-enables tests Attachment 322156 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/4694720 New failing tests: editing/pasteboard/pasting-empty-html-falls-back-to-text.html editing/pasteboard/onpaste-text-html-types.html
Build Bot
Comment 3 2017-09-28 21:15:13 PDT
Created attachment 322166 [details] Archive of layout-test-results from ews123 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews123 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.6
Ryosuke Niwa
Comment 4 2017-09-28 22:47:52 PDT
Created attachment 322172 [details] Patch
Wenson Hsieh
Comment 5 2017-09-29 07:20:18 PDT
Comment on attachment 322172 [details] Patch Nice! rs=me
Wenson Hsieh
Comment 6 2017-09-29 07:50:08 PDT
As an aside, I should also see what other editing/pasteboard/ tests <http://trac.webkit.org/r222595> fixes if I additionally enable the internal settings switch for custom pasteboard data...
Ryosuke Niwa
Comment 7 2017-09-29 11:34:56 PDT
(In reply to Wenson Hsieh from comment #6) > As an aside, I should also see what other editing/pasteboard/ tests > <http://trac.webkit.org/r222595> fixes if I additionally enable the internal > settings switch for custom pasteboard data... Yeah, we might want to turn that on by default inside DRT/WTR.
Ryosuke Niwa
Comment 8 2017-09-29 11:37:30 PDT
Comment on attachment 322172 [details] Patch Clearing flags on attachment: 322172 Committed r222655: <http://trac.webkit.org/changeset/222655>
Ryosuke Niwa
Comment 9 2017-09-29 11:37:32 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 10 2017-09-29 11:38:39 PDT
<rdar://problem/34743911>
Note You need to log in before you can comment on or make changes to this bug.