Bug 177621

Summary: Re-write Settings generation in python for some reason
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, commit-queue, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
thorton: review+
Patch
none
Patch
none
Patch
none
Patch
none
Patch
buildbot: commit-queue-
Archive of layout-test-results from ews122 for ios-simulator-wk2 none

Sam Weinig
Reported 2017-09-28 14:23:55 PDT
Re-write Settings generation in python for some reason
Attachments
Patch (62.24 KB, patch)
2017-09-28 14:35 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (62.33 KB, patch)
2017-09-28 15:09 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (64.25 KB, patch)
2017-09-28 15:24 PDT, Sam Weinig 		thorton: review+
DetailsFormatted DiffDiff
Patch (64.33 KB, patch)
2017-09-28 17:06 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (64.88 KB, patch)
2017-09-28 19:53 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (64.91 KB, patch)
2017-09-28 20:08 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (64.72 KB, patch)
2017-09-28 20:56 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (64.72 KB, patch)
2017-09-28 21:09 PDT, Sam Weinig 		buildbot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews122 for ios-simulator-wk2 (997.74 KB, application/zip)
2017-09-28 22:43 PDT, Build Bot 		no flags
Details
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2017-09-28 14:25:53 PDT
I decided to re-write make_settings.pl in python. Given that much of (most?) our scripts are now in python, this seemed like the prudent thing to do before changing things too much.
Sam Weinig
Comment 2 2017-09-28 14:35:00 PDT
Created attachment 322118 [details] Patch
Build Bot
Comment 3 2017-09-28 14:36:39 PDT Comment hidden (obsolete)
Tim Horton
Comment 4 2017-09-28 14:38:18 PDT Comment hidden (obsolete)
Sam Weinig
Comment 5 2017-09-28 15:09:03 PDT Comment hidden (obsolete)
Sam Weinig
Comment 6 2017-09-28 15:24:46 PDT
Created attachment 322126 [details] Patch
Sam Weinig
Comment 7 2017-09-28 17:06:07 PDT
Created attachment 322147 [details] Patch
Sam Weinig
Comment 8 2017-09-28 19:53:59 PDT
Created attachment 322158 [details] Patch
Sam Weinig
Comment 9 2017-09-28 20:08:25 PDT
Created attachment 322159 [details] Patch
Sam Weinig
Comment 10 2017-09-28 20:56:15 PDT
Created attachment 322164 [details] Patch
Sam Weinig
Comment 11 2017-09-28 21:09:07 PDT
Created attachment 322165 [details] Patch
WebKit Commit Bot
Comment 12 2017-09-28 22:38:01 PDT
Comment on attachment 322165 [details] Patch Clearing flags on attachment: 322165 Committed r222647: <http://trac.webkit.org/changeset/222647>
Build Bot
Comment 13 2017-09-28 22:43:06 PDT
Comment on attachment 322165 [details] Patch Attachment 322165 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/4695355 New failing tests: imported/w3c/web-platform-tests/WebCryptoAPI/import_export/test_rsa_importKey.https.html
Build Bot
Comment 14 2017-09-28 22:43:07 PDT
Created attachment 322171 [details] Archive of layout-test-results from ews122 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews122 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.6
Radar WebKit Bug Importer
Comment 15 2017-09-29 03:10:49 PDT
<rdar://problem/34735791>
Note You need to log in before you can comment on or make changes to this bug.