177621 – Re-write Settings generation in python for some reason

RESOLVED FIXED177621

Re-write Settings generation in python for some reason

https://bugs.webkit.org/show_bug.cgi?id=177621

Summary Re-write Settings generation in python for some reason

Sam Weinig

Reported 2017-09-28 14:23:55 PDT

Re-write Settings generation in python for some reason

Attachments
Patch (62.24 KB, patch) 2017-09-28 14:35 PDT, Sam Weinig	no flags	Details Formatted Diff Diff
Patch (62.33 KB, patch) 2017-09-28 15:09 PDT, Sam Weinig	no flags	Details Formatted Diff Diff
Patch (64.25 KB, patch) 2017-09-28 15:24 PDT, Sam Weinig	thorton: review+	Details Formatted Diff Diff
Patch (64.33 KB, patch) 2017-09-28 17:06 PDT, Sam Weinig	no flags	Details Formatted Diff Diff
Patch (64.88 KB, patch) 2017-09-28 19:53 PDT, Sam Weinig	no flags	Details Formatted Diff Diff
Patch (64.91 KB, patch) 2017-09-28 20:08 PDT, Sam Weinig	no flags	Details Formatted Diff Diff
Patch (64.72 KB, patch) 2017-09-28 20:56 PDT, Sam Weinig	no flags	Details Formatted Diff Diff
Patch (64.72 KB, patch) 2017-09-28 21:09 PDT, Sam Weinig	buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews122 for ios-simulator-wk2 (997.74 KB, application/zip) 2017-09-28 22:43 PDT, Build Bot	no flags	Details
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.

Sam Weinig

Comment 1 2017-09-28 14:25:53 PDT

I decided to re-write make_settings.pl in python. Given that much of (most?) our scripts are now in python, this seemed like the prudent thing to do before changing things too much.

Sam Weinig

Comment 2 2017-09-28 14:35:00 PDT

Created attachment 322118 [details] Patch

Build Bot

Comment 3 2017-09-28 14:36:39 PDT Comment hidden (obsolete)

Attachment 322118 [details] did not pass style-queue: ERROR: Source/WebCore/Scripts/GenerateSettings/GenerateSettingsMacrosHeader.py:30: expected 2 blank lines, found 1 [pep8/E302] [5] ERROR: Source/WebCore/Scripts/GenerateSettings/GenerateSettingsMacrosHeader.py:33: trailing whitespace [pep8/W291] [5] ERROR: Source/WebCore/Scripts/GenerateSettings/GenerateSettingsMacrosHeader.py:42: trailing whitespace [pep8/W291] [5] ERROR: Source/WebCore/Scripts/GenerateSettings/GenerateSettingsMacrosHeader.py:58: multiple statements on one line (semicolon) [pep8/E702] [5] ERROR: Source/WebCore/Scripts/GenerateSettings/GenerateSettingsMacrosHeader.py:59: multiple statements on one line (semicolon) [pep8/E702] [5] ERROR: Source/WebCore/Scripts/GenerateSettings/GenerateSettingsMacrosHeader.py:60: multiple statements on one line (semicolon) [pep8/E702] [5] ERROR: Source/WebCore/Scripts/GenerateSettings/GenerateSettingsMacrosHeader.py:61: multiple statements on one line (semicolon) [pep8/E702] [5] ERROR: Source/WebCore/Scripts/GenerateSettings/GenerateSettingsMacrosHeader.py:63: multiple statements on one line (semicolon) [pep8/E702] [5] ERROR: Source/WebCore/Scripts/GenerateSettings/GenerateSettingsMacrosHeader.py:123: trailing whitespace [pep8/W291] [5] ERROR: Source/WebCore/Scripts/GenerateSettings/GenerateSettingsMacrosHeader.py:127: too many blank lines (2) [pep8/E303] [5] ERROR: Source/WebCore/Scripts/GenerateSettings/GenerateSettingsMacrosHeader.py:134: trailing whitespace [pep8/W291] [5] ERROR: Source/WebCore/Scripts/GenerateSettings/GenerateSettingsMacrosHeader.py:144: trailing whitespace [pep8/W291] [5] ERROR: Source/WebCore/Scripts/GenerateSettings/GenerateSettingsMacrosHeader.py:150: too many blank lines (2) [pep8/E303] [5] ERROR: Source/WebCore/Scripts/GenerateSettings/GenerateSettingsMacrosHeader.py:159: trailing whitespace [pep8/W291] [5] ERROR: Source/WebCore/Scripts/GenerateSettings/GenerateSettingsMacrosHeader.py:171: trailing whitespace [pep8/W291] [5] ERROR: Source/WebCore/Scripts/GenerateSettings/GenerateSettingsMacrosHeader.py:177: too many blank lines (2) [pep8/E303] [5] ERROR: Source/WebCore/Scripts/GenerateSettings/GenerateSettingsMacrosHeader.py:204: trailing whitespace [pep8/W291] [5] ERROR: Source/WebCore/Scripts/GenerateSettings/GenerateSettingsMacrosHeader.py:68: [printGetterAndSetter] Undefined variable 'makeSetterFunctionName' [pylint/E0602] [5] ERROR: Source/WebCore/Scripts/GenerateSettings/GenerateSettingsMacrosHeader.py:92: [printSetterBody] Undefined variable 'makeSetterFunctionName' [pylint/E0602] [5] ERROR: Source/WebCore/Scripts/GenerateSettings/GenerateSettingsMacrosHeader.py:109: [printConditionalMacros] Undefined variable 'makeConditionalString' [pylint/E0602] [5] ERROR: Source/WebCore/Scripts/GenerateSettings/GenerateSettingsMacrosHeader.py:115: [printConditionalMacros] Undefined variable 'makePreferredConditional' [pylint/E0602] [5] ERROR: Source/WebCore/Scripts/GenerateSettings/GenerateSettingsMacrosHeader.py:203: [printGettersAndSetters] Undefined variable 'makePreferredConditional' [pylint/E0602] [5] ERROR: Source/WebCore/Scripts/GenerateSettings/GenerateSettingsMacrosHeader.py:220: [printMemberVariables] Undefined variable 'makePreferredConditional' [pylint/E0602] [5] ERROR: Source/WebCore/Scripts/GenerateSettings/GenerateSettingsMacrosHeader.py:229: [printMemberVariables] Undefined variable 'makePreferredConditional' [pylint/E0602] [5] ERROR: Source/WebCore/Scripts/GenerateSettings/GenerateSettingsMacrosHeader.py:248: [printInitializerList] Undefined variable 'makePreferredConditional' [pylint/E0602] [5] ERROR: Source/WebCore/Scripts/GenerateSettings/GenerateSettingsMacrosHeader.py:259: [printInitializerList] Undefined variable 'makePreferredConditional' [pylint/E0602] [5] ERROR: Source/WebCore/Scripts/GenerateSettings/GenerateSettingsMacrosHeader.py:272: [printSetterBodies] Undefined variable 'makePreferredConditional' [pylint/E0602] [5] ERROR: Source/WebCore/Scripts/GenerateSettings.py:31: expected 2 blank lines, found 1 [pep8/E302] [5] ERROR: Source/WebCore/Scripts/GenerateSettings.py:43: multiple statements on one line (semicolon) [pep8/E702] [5] ERROR: Source/WebCore/Scripts/GenerateSettings.py:52: multiple statements on one line (semicolon) [pep8/E702] [5] ERROR: Source/WebCore/Scripts/GenerateSettings.py:53: multiple statements on one line (semicolon) [pep8/E702] [5] ERROR: Source/WebCore/Scripts/GenerateSettings/GenerateInternalSettingsImplementationFile.py:28: trailing whitespace [pep8/W291] [5] ERROR: Source/WebCore/Scripts/GenerateSettings/GenerateInternalSettingsImplementationFile.py:30: expected 2 blank lines, found 1 [pep8/E302] [5] ERROR: Source/WebCore/Scripts/GenerateSettings/GenerateInternalSettingsImplementationFile.py:64: too many blank lines (2) [pep8/E303] [5] ERROR: Source/WebCore/Scripts/GenerateSettings/GenerateInternalSettingsImplementationFile.py:69: too many blank lines (2) [pep8/E303] [5] ERROR: Source/WebCore/Scripts/GenerateSettings/GenerateInternalSettingsImplementationFile.py:89: too many blank lines (2) [pep8/E303] [5] ERROR: Source/WebCore/Scripts/GenerateSettings/GenerateInternalSettingsImplementationFile.py:109: trailing whitespace [pep8/W291] [5] ERROR: Source/WebCore/Scripts/GenerateSettings/GenerateInternalSettingsImplementationFile.py:115: blank line at end of file [pep8/W391] [5] ERROR: Source/WebCore/Scripts/GenerateSettings/GenerateInternalSettingsImplementationFile.py:48: [generateInternalSettingsImplementationFile] Undefined variable 'mapToIDLType' [pylint/E0602] [5] ERROR: Source/WebCore/Scripts/GenerateSettings/GenerateInternalSettingsImplementationFile.py:53: [generateInternalSettingsImplementationFile] Undefined variable 'makeConditionalString' [pylint/E0602] [5] ERROR: Source/WebCore/Scripts/GenerateSettings/GenerateInternalSettingsImplementationFile.py:74: [generateInternalSettingsImplementationFile] Undefined variable 'mapToIDLType' [pylint/E0602] [5] ERROR: Source/WebCore/Scripts/GenerateSettings/GenerateInternalSettingsImplementationFile.py:79: [generateInternalSettingsImplementationFile] Undefined variable 'makeConditionalString' [pylint/E0602] [5] ERROR: Source/WebCore/Scripts/GenerateSettings/GenerateInternalSettingsImplementationFile.py:81: [generateInternalSettingsImplementationFile] Undefined variable 'makeSetterFunctionName' [pylint/E0602] [5] ERROR: Source/WebCore/Scripts/GenerateSettings/GenerateInternalSettingsImplementationFile.py:91: [generateInternalSettingsImplementationFile] Undefined variable 'mapToIDLType' [pylint/E0602] [5] ERROR: Source/WebCore/Scripts/GenerateSettings/GenerateInternalSettingsImplementationFile.py:97: [generateInternalSettingsImplementationFile] Undefined variable 'makeSetterFunctionName' [pylint/E0602] [5] ERROR: Source/WebCore/Scripts/GenerateSettings/GenerateInternalSettingsImplementationFile.py:101: [generateInternalSettingsImplementationFile] Undefined variable 'makeConditionalString' [pylint/E0602] [5] ERROR: Source/WebCore/Scripts/GenerateSettings/GenerateInternalSettingsImplementationFile.py:103: [generateInternalSettingsImplementationFile] Undefined variable 'makeSetterFunctionName' [pylint/E0602] [5] ERROR: Source/WebCore/Scripts/GenerateSettings/GenerateInternalSettingsHeaderFile.py:28: trailing whitespace [pep8/W291] [5] ERROR: Source/WebCore/Scripts/GenerateSettings/GenerateInternalSettingsHeaderFile.py:30: expected 2 blank lines, found 1 [pep8/E302] [5] ERROR: Source/WebCore/Scripts/GenerateSettings/GenerateInternalSettingsHeaderFile.py:36: too many blank lines (2) [pep8/E303] [5] ERROR: Source/WebCore/Scripts/GenerateSettings/GenerateInternalSettingsHeaderFile.py:80: too many blank lines (2) [pep8/E303] [5] ERROR: Source/WebCore/Scripts/GenerateSettings/GenerateInternalSettingsHeaderFile.py:81: multiple statements on one line (semicolon) [pep8/E702] [5] ERROR: Source/WebCore/Scripts/GenerateSettings/GenerateInternalSettingsHeaderFile.py:84: blank line at end of file [pep8/W391] [5] ERROR: Source/WebCore/Scripts/GenerateSettings/GenerateInternalSettingsHeaderFile.py:54: [generateInternalSettingsHeaderFile] Undefined variable 'mapToIDLType' [pylint/E0602] [5] ERROR: Source/WebCore/Scripts/GenerateSettings/GenerateInternalSettingsHeaderFile.py:59: [generateInternalSettingsHeaderFile] Undefined variable 'makeSetterFunctionName' [pylint/E0602] [5] ERROR: Source/WebCore/Scripts/GenerateSettings/GenerateInternalSettingsHeaderFile.py:67: [generateInternalSettingsHeaderFile] Undefined variable 'mapToIDLType' [pylint/E0602] [5] ERROR: Source/WebCore/Scripts/GenerateSettings/GenerateInternalSettingsHeaderFile.py:72: [generateInternalSettingsHeaderFile] Undefined variable 'makeConditionalString' [pylint/E0602] [5] ERROR: Source/WebCore/Scripts/GenerateSettings/Settings.py:29: expected 2 blank lines, found 1 [pep8/E302] [5] ERROR: Source/WebCore/Scripts/GenerateSettings/Settings.py:59: expected 2 blank lines, found 1 [pep8/E302] [5] ERROR: Source/WebCore/Scripts/GenerateSettings/Settings.py:68: multiple spaces after operator [pep8/E222] [5] ERROR: Source/WebCore/Scripts/GenerateSettings/Settings.py:114: expected 2 blank lines, found 1 [pep8/E302] [5] ERROR: Source/WebCore/Scripts/GenerateSettings/Settings.py:118: trailing whitespace [pep8/W291] [5] ERROR: Source/WebCore/Scripts/GenerateSettings/Settings.py:120: trailing whitespace [pep8/W291] [5] ERROR: Source/WebCore/Scripts/GenerateSettings/Settings.py:122: trailing whitespace [pep8/W291] [5] ERROR: Source/WebCore/Scripts/GenerateSettings/GenerateInternalSettingsIDLFile.py:28: trailing whitespace [pep8/W291] [5] ERROR: Source/WebCore/Scripts/GenerateSettings/GenerateInternalSettingsIDLFile.py:30: expected 2 blank lines, found 1 [pep8/E302] [5] ERROR: Source/WebCore/Scripts/GenerateSettings/GenerateInternalSettingsIDLFile.py:49: blank line at end of file [pep8/W391] [5] Total errors found: 67 in 11 files If any of these errors are false positives, please file a bug against check-webkit-style.

Tim Horton

Comment 4 2017-09-28 14:38:18 PDT Comment hidden (obsolete)

Comment on attachment 322118 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=322118&action=review > Source/WebCore/Scripts/GenerateSettings.py:43 > + outputDirectory = os.path.abspath(options.outputDir) if options.outputDir else os.getcwd(); no semicolon > Source/WebCore/Scripts/GenerateSettings.py:46 > + print outputDirectory > + exit(-1) wat > Source/WebCore/Scripts/GenerateSettings.py:53 > + generateInternalSettingsHeaderFile(outputDirectory, settings); > + generateInternalSettingsImplementationFile(outputDirectory, settings); good lord semicolons

Sam Weinig

Comment 5 2017-09-28 15:09:03 PDT Comment hidden (obsolete)

Created attachment 322124 [details] Patch

Sam Weinig

Comment 6 2017-09-28 15:24:46 PDT

Created attachment 322126 [details] Patch

Sam Weinig

Comment 7 2017-09-28 17:06:07 PDT

Created attachment 322147 [details] Patch

Sam Weinig

Comment 8 2017-09-28 19:53:59 PDT

Created attachment 322158 [details] Patch

Sam Weinig

Comment 9 2017-09-28 20:08:25 PDT

Created attachment 322159 [details] Patch

Sam Weinig

Comment 10 2017-09-28 20:56:15 PDT

Created attachment 322164 [details] Patch

Sam Weinig

Comment 11 2017-09-28 21:09:07 PDT

Created attachment 322165 [details] Patch

WebKit Commit Bot

Comment 12 2017-09-28 22:38:01 PDT

Comment on attachment 322165 [details] Patch Clearing flags on attachment: 322165 Committed r222647: <http://trac.webkit.org/changeset/222647>

Build Bot

Comment 13 2017-09-28 22:43:06 PDT

Comment on attachment 322165 [details] Patch Attachment 322165 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/4695355 New failing tests: imported/w3c/web-platform-tests/WebCryptoAPI/import_export/test_rsa_importKey.https.html

Build Bot

Comment 14 2017-09-28 22:43:07 PDT

Created attachment 322171 [details] Archive of layout-test-results from ews122 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews122 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.6

Radar WebKit Bug Importer

Comment 15 2017-09-29 03:10:49 PDT

<rdar://problem/34735791>

Note You need to log in before you can comment on or make changes to this bug.

Status RESOLVED

Resolution FIXED

Priority P2

Severity Normal

Classification Unclassified

Version WebKit Nightly Build

Hardware Unspecified

OS Unspecified

Product WebKit

Component New Bugs

Assignee

Sam Weinig

Reported

2017-09-28 14:23 PDT

Modified

2017-09-29 03:10 PDT History

CC List

4 users Show

URL

Keywords InRadar

Depends on

Blocks