Bug 177613

Summary: Web Inspector: Remove Error icon in error message for resources it looks poor
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, inspector-bugzilla-changes, joepeck, mattbaker, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
[IMAGE] Before - wide
none
[IMAGE] After - wide
none
[IMAGE] Before - narrow
none
[IMAGE] After - narrow
none
[PATCH] Proposed Fix none

Joseph Pecoraro
Reported 2017-09-28 12:27:42 PDT
Remove Error icon in error message for resources it looks poor. It looks especially poor when the message is narrow and spans multiple lines, the icon is tiny and cramps the text.
Attachments
[IMAGE] Before - wide (129.27 KB, image/png)
2017-09-28 12:28 PDT, Joseph Pecoraro 		no flags
Details
[IMAGE] After - wide (127.83 KB, image/png)
2017-09-28 12:28 PDT, Joseph Pecoraro 		no flags
Details
[IMAGE] Before - narrow (123.64 KB, image/png)
2017-09-28 12:28 PDT, Joseph Pecoraro 		no flags
Details
[IMAGE] After - narrow (122.65 KB, image/png)
2017-09-28 12:28 PDT, Joseph Pecoraro 		no flags
Details
[PATCH] Proposed Fix (1.40 KB, patch)
2017-09-28 12:29 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1 2017-09-28 12:28:05 PDT
Created attachment 322105 [details] [IMAGE] Before - wide
Joseph Pecoraro
Comment 2 2017-09-28 12:28:17 PDT
Created attachment 322106 [details] [IMAGE] After - wide
Joseph Pecoraro
Comment 3 2017-09-28 12:28:35 PDT
Created attachment 322107 [details] [IMAGE] Before - narrow
Joseph Pecoraro
Comment 4 2017-09-28 12:28:45 PDT
Created attachment 322108 [details] [IMAGE] After - narrow
Joseph Pecoraro
Comment 5 2017-09-28 12:29:24 PDT
Created attachment 322109 [details] [PATCH] Proposed Fix
Matt Baker
Comment 6 2017-09-28 12:38:24 PDT
Comment on attachment 322109 [details] [PATCH] Proposed Fix Looks better! r=me
WebKit Commit Bot
Comment 7 2017-09-28 13:18:09 PDT
Comment on attachment 322109 [details] [PATCH] Proposed Fix Clearing flags on attachment: 322109 Committed r222630: <http://trac.webkit.org/changeset/222630>
WebKit Commit Bot
Comment 8 2017-09-28 13:18:11 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 9 2017-09-28 13:19:23 PDT
<rdar://problem/34722580>
Note You need to log in before you can comment on or make changes to this bug.