| Summary: | Overlapping text on all CSS fonts specs | ||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Myles C. Maxfield <mmaxfield> | ||||||||||||||||||
| Component: | Layout and Rendering | Assignee: | Antti Koivisto <koivisto> | ||||||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||||||
| Severity: | Normal | CC: | ap, bfulgham, buildbot, commit-queue, dbates, info, jasbir.sandhu, koivisto, simon.fraser, webkit-bug-importer, zalan | ||||||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||||||
| OS: | Unspecified | ||||||||||||||||||||
| Attachments: |
|
||||||||||||||||||||
|
Description
Myles C. Maxfield
2017-09-27 18:50:13 PDT
How to resolve it in Safari 11. Created attachment 323924 [details]
Test reduction
style().computedLineHeight() looks unresolved (value of 1) <details><summary></summary></details><li>foobar</li> 1. <li> has rem based line-height. 2. CSS_REMS is resolved using conversionData.rootStyle() 3. CSSToLengthConversionData uses StyleResolver's m_rootElementStyle - 4. The <details>'s element shadow tree triggers scoping (TreeResolver::pushScope()) 5. While popping the scope, we also clear the scope's styleResolver's m_rootElementStyle (TreeResolver::popScope) 6. Since we reuse the style resolver, this reset affects style resolving of the elements outside of the shadow tree. (the <li> element) -> see #1. Created attachment 324113 [details]
patch
Created attachment 324114 [details]
patch
Comment on attachment 324114 [details] patch Attachment 324114 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/4902386 New failing tests: fast/shadow-dom/copy-shadow-tree.html Created attachment 324118 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.6
Comment on attachment 324114 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=324114&action=review > LayoutTests/fast/html/details-line-height-overlap-expected.html:1 > +<html> Is it necessary to use quirks mode to render this file? Also, the markup in this document is not well-formed. Is this intentional? If we do not need quirks mode then please add <!DOCTYPE html>. > LayoutTests/fast/html/details-line-height-overlap.html:1 > +<html> Ditto. (In reply to Build Bot from comment #8) > Comment on attachment 324114 [details] > patch > > Attachment 324114 [details] did not pass ios-sim-ews (ios-simulator-wk2): > Output: http://webkit-queues.webkit.org/results/4902386 > > New failing tests: > fast/shadow-dom/copy-shadow-tree.html Don't know why this is showing up, it appears to be skipped for all platforms. > Don't know why this is showing up, it appears to be skipped for all platforms. All tests in this directory are overridden in iOS test expectations as passing, see LayoutTests/platform/ios/TestExpectations:347 webkit.org/b/148695 fast/shadow-dom [ Pass ] Looks like that tests used to pass before this patch! 46$ $ ./Tools/Scripts/run-webkit-tests fast/shadow-dom/copy-shadow-tree.html --ios-simulator --print-expectations Found 1 test; running 1, skipping 0. Tests to run (1) fast/shadow-dom/copy-shadow-tree.html ['PASS'] LayoutTests/platform/ios/TestExpectations:347 webkit.org/b/148695 fast/shadow-dom [ Pass ] Created attachment 324217 [details]
patch
Created attachment 324218 [details]
patch
Comment on attachment 324218 [details] patch Rejecting attachment 324218 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 324218, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Dan Bates found in /Volumes/Data/EWS/WebKit/LayoutTests/ChangeLog does not appear to be a valid reviewer according to contributors.json. /Volumes/Data/EWS/WebKit/LayoutTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://webkit-queues.webkit.org/results/4918685 Created attachment 324221 [details]
patch
Comment on attachment 324221 [details] patch Clearing flags on attachment: 324221 Committed r223688: <https://trac.webkit.org/changeset/223688> All reviewed patches have been landed. Closing bug. *** Bug 173876 has been marked as a duplicate of this bug. *** |