Bug 177560

Summary: Blurry captions on retina screens.
Product: WebKit Reporter: Jeremy Jones <jeremyj-wk>
Component: MediaAssignee: Jeremy Jones <jeremyj-wk>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric.carlson, jer.noble, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
jer.noble: review+
Patch for landing none

Jeremy Jones
Reported 2017-09-27 12:23:58 PDT
Blurry captions on retina screens.
Attachments
Patch (2.52 KB, patch)
2017-09-27 12:29 PDT, Jeremy Jones 		jer.noble: review+
DetailsFormatted DiffDiff
Patch for landing (2.52 KB, patch)
2017-10-03 12:14 PDT, Jeremy Jones 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jeremy Jones
Comment 1 2017-09-27 12:24:54 PDT
rdar://problem/17913388
Jeremy Jones
Comment 2 2017-09-27 12:29:14 PDT
Created attachment 321997 [details] Patch
Jer Noble
Comment 3 2017-10-03 12:09:03 PDT
Comment on attachment 321997 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=321997&action=review > Source/WebCore/html/shadow/MediaControlElements.cpp:1369 > + videoBox.setWidth(videoBox.width()*deviceScaleFactor); > + videoBox.setHeight(videoBox.height()*deviceScaleFactor); Nit: spaces around the "*".
Jeremy Jones
Comment 4 2017-10-03 12:14:47 PDT
Created attachment 322559 [details] Patch for landing
Jeremy Jones
Comment 5 2017-10-03 12:24:42 PDT
(In reply to Jer Noble from comment #3) > Comment on attachment 321997 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=321997&action=review > > > Source/WebCore/html/shadow/MediaControlElements.cpp:1369 > > + videoBox.setWidth(videoBox.width()*deviceScaleFactor); > > + videoBox.setHeight(videoBox.height()*deviceScaleFactor); > > Nit: spaces around the "*". Done.
WebKit Commit Bot
Comment 6 2017-10-09 10:56:38 PDT
Comment on attachment 322559 [details] Patch for landing Clearing flags on attachment: 322559 Committed r223052: <http://trac.webkit.org/changeset/223052>
Note You need to log in before you can comment on or make changes to this bug.