Bug 177544

Summary:

Add ports 6679 and 6697 (IRC SSL) to port blacklist

Product:

WebKit

Reporter:

Brent Fulgham <bfulgham>

Component:

WebCore Misc.

Assignee:

Brent Fulgham <bfulgham>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, bfulgham, buildbot, cdumez, mcatanzaro, rniwa, sam

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews102 for mac-elcapitan	none
Patch	none
Patch	achristensen: review+

Description Brent Fulgham 2017-09-27 08:53:51 PDT

Update our port blocking blacklist to match Chrome's list.

We should not see any compatibility impact here, since Chrome has been blocking this port for a long time.

Comment 1 Brent Fulgham 2017-09-27 08:54:11 PDT

<rdar://problem/34666525>

Comment 2 Brent Fulgham 2017-09-27 08:56:13 PDT

Created attachment 321962 [details]
Patch

Comment 3 Build Bot 2017-09-27 10:04:18 PDT

Comment on attachment 321962 [details]
Patch

Attachment 321962 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/4676747

New failing tests:
security/block-test.html

Comment 4 Build Bot 2017-09-27 10:04:19 PDT

Created attachment 321968 [details]
Archive of layout-test-results from ews102 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

Comment 5 Brent Fulgham 2017-09-27 10:11:15 PDT

Created attachment 321969 [details]
Patch

Comment 6 Alex Christensen 2017-09-27 10:21:55 PDT

Comment on attachment 321969 [details]
Patch

Wikipedia says 6697 is the official number and 6679 the unofficial number.  Do we want to block both?

Comment 7 Brent Fulgham 2017-09-27 10:25:26 PDT

(In reply to Alex Christensen from comment #6)
> Comment on attachment 321969 [details]
> Patch
> 
> Wikipedia says 6697 is the official number and 6679 the unofficial number. 
> Do we want to block both?

Yes. :-)

Comment 8 Sam Weinig 2017-09-27 10:27:22 PDT

Please file a bug to update the port blocking part of the fetch spec, https://fetch.spec.whatwg.org/#port-blocking.

Comment 9 Brent Fulgham 2017-09-27 10:27:35 PDT

(In reply to Brent Fulgham from comment #7)
> (In reply to Alex Christensen from comment #6)
> > Comment on attachment 321969 [details]
> > Patch
> > 
> > Wikipedia says 6697 is the official number and 6679 the unofficial number. 
> > Do we want to block both?
> 
> Yes. :-)

Oh, wait =- I'm not sure. I don't think Chrome does, so we might create some compatibility issues if we did.

Comment 10 Sam Weinig 2017-09-27 10:27:46 PDT

Comment on attachment 321969 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=321969&action=review

> Source/WebCore/platform/URL.cpp:1281
> +        6679, // Alternate IRC SSL [Apple addition]

Why [Apple addition] if this came from Chrome?

Comment 11 Brent Fulgham 2017-09-27 10:37:45 PDT

(In reply to Sam Weinig from comment #10)
> Comment on attachment 321969 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=321969&action=review
> 
> > Source/WebCore/platform/URL.cpp:1281
> > +        6679, // Alternate IRC SSL [Apple addition]
> 
> Why [Apple addition] if this came from Chrome?

It's an Apple addition (in our sources) to a list provided by Mozilla.

I could mark it as Chrome, but I don't think we've done that with other similar changes.

Comment 12 Brent Fulgham 2017-09-28 10:14:25 PDT

(In reply to Alex Christensen from comment #6)
> Comment on attachment 321969 [details]
> Patch
> 
> Wikipedia says 6697 is the official number and 6679 the unofficial number. 
> Do we want to block both?

I checked with some people, and we decided that yes, we should block both. I've updated the bug to reflect this.

Comment 13 Brent Fulgham 2017-09-28 10:16:46 PDT

Created attachment 322095 [details]
Patch

Comment 14 Brent Fulgham 2017-09-28 12:22:50 PDT

Committed r222623: <http://trac.webkit.org/changeset/222623>