Bug 177544

Summary:

Add ports 6679 and 6697 (IRC SSL) to port blacklist

Product:

WebKit

Reporter:

Brent Fulgham <bfulgham>

Component:

WebCore Misc.

Assignee:

Brent Fulgham <bfulgham>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, bfulgham, buildbot, cdumez, mcatanzaro, rniwa, sam

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews102 for mac-elcapitan	none
Patch	none
Patch	achristensen: review+

Brent Fulgham

Reported 2017-09-27 08:53:51 PDT

Update our port blocking blacklist to match Chrome's list. We should not see any compatibility impact here, since Chrome has been blocking this port for a long time.

Attachments
Patch (4.19 KB, patch) 2017-09-27 08:56 PDT, Brent Fulgham	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews102 for mac-elcapitan (1012.02 KB, application/zip) 2017-09-27 10:04 PDT, Build Bot	no flags	Details
Patch (9.55 KB, patch) 2017-09-27 10:11 PDT, Brent Fulgham	no flags	Details Formatted Diff Diff
Patch (10.99 KB, patch) 2017-09-28 10:16 PDT, Brent Fulgham	achristensen: review+	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Brent Fulgham

Comment 1 2017-09-27 08:54:11 PDT

<rdar://problem/34666525>

Brent Fulgham

Comment 2 2017-09-27 08:56:13 PDT

Created attachment 321962 [details] Patch

Build Bot

Comment 3 2017-09-27 10:04:18 PDT

Comment on attachment 321962 [details] Patch Attachment 321962 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/4676747 New failing tests: security/block-test.html

Build Bot

Comment 4 2017-09-27 10:04:19 PDT

Created attachment 321968 [details] Archive of layout-test-results from ews102 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Brent Fulgham

Comment 5 2017-09-27 10:11:15 PDT

Created attachment 321969 [details] Patch

Alex Christensen

Comment 6 2017-09-27 10:21:55 PDT

Comment on attachment 321969 [details] Patch Wikipedia says 6697 is the official number and 6679 the unofficial number. Do we want to block both?

Brent Fulgham

Comment 7 2017-09-27 10:25:26 PDT

Sam Weinig

Comment 8 2017-09-27 10:27:22 PDT

Please file a bug to update the port blocking part of the fetch spec, https://fetch.spec.whatwg.org/#port-blocking.

Brent Fulgham

Comment 9 2017-09-27 10:27:35 PDT

(In reply to Brent Fulgham from comment #7) > (In reply to Alex Christensen from comment #6) > > Comment on attachment 321969 [details] > > Patch > > > > Wikipedia says 6697 is the official number and 6679 the unofficial number. > > Do we want to block both? > > Yes. :-) Oh, wait =- I'm not sure. I don't think Chrome does, so we might create some compatibility issues if we did.

Sam Weinig

Comment 10 2017-09-27 10:27:46 PDT

Comment on attachment 321969 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=321969&action=review > Source/WebCore/platform/URL.cpp:1281 > + 6679, // Alternate IRC SSL [Apple addition] Why [Apple addition] if this came from Chrome?

Brent Fulgham

Comment 11 2017-09-27 10:37:45 PDT

(In reply to Sam Weinig from comment #10) > Comment on attachment 321969 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=321969&action=review > > > Source/WebCore/platform/URL.cpp:1281 > > + 6679, // Alternate IRC SSL [Apple addition] > > Why [Apple addition] if this came from Chrome? It's an Apple addition (in our sources) to a list provided by Mozilla. I could mark it as Chrome, but I don't think we've done that with other similar changes.

Brent Fulgham

Comment 12 2017-09-28 10:14:25 PDT

(In reply to Alex Christensen from comment #6) > Comment on attachment 321969 [details] > Patch > > Wikipedia says 6697 is the official number and 6679 the unofficial number. > Do we want to block both? I checked with some people, and we decided that yes, we should block both. I've updated the bug to reflect this.

Brent Fulgham

Comment 13 2017-09-28 10:16:46 PDT

Created attachment 322095 [details] Patch

Brent Fulgham

Comment 14 2017-09-28 12:22:50 PDT

Committed r222623: <http://trac.webkit.org/changeset/222623>

Note You need to log in before you can comment on or make changes to this bug.