Bug 177531

Summary: REGRESSION (r222040): Crash navigating out of gfycat.com url
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: CSSAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, cdumez, cmarcelo, commit-queue, dbates, dino, dstockwell, esprehn+autocc, ggaren, kangil.han, simon.fraser
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch ggaren: review+

Antti Koivisto
Reported 2017-09-27 04:42:18 PDT
1) https://gfycat.com/HoarseMadeupEuropeanpolecat 2) press back
Attachments
patch (8.09 KB, patch)
2017-09-27 04:54 PDT, Antti Koivisto 		ggaren: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2017-09-27 04:44:46 PDT
<rdar://problem/34602601>
Antti Koivisto
Comment 2 2017-09-27 04:54:26 PDT
Created attachment 321954 [details] patch
Geoffrey Garen
Comment 3 2017-09-27 08:03:18 PDT
Comment on attachment 321954 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=321954&action=review r=me > Source/WebCore/dom/ElementRareData.h:111 > + void setHasCSSAnimation(bool b) { m_hasCSSAnimation = b; } WebKit style says the argument name should be "hasCSSAnimation".
Antti Koivisto
Comment 4 2017-09-27 08:33:30 PDT
https://trac.webkit.org/r222554
Antti Koivisto
Comment 5 2017-09-27 08:35:53 PDT
> WebKit style says the argument name should be "hasCSSAnimation". That seems bit redundant. I called it 'value' which looks like a Common WebKit Pattern.
Note You need to log in before you can comment on or make changes to this bug.