Bug 177522

Summary: Web Inspector: Remove unused parameter of Page.reload
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, inspector-bugzilla-changes, joepeck, keith_miller, mark.lam, mattbaker, msaboff, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Proposed Fix mattbaker: review+

Joseph Pecoraro
Reported 2017-09-26 22:32:22 PDT
Web Inspector: Remove unused parameter of Page.reload We have never used it in our frontend and it doesn't seem like we will soon.
Attachments
[PATCH] Proposed Fix (7.65 KB, patch)
2017-09-26 23:06 PDT, Joseph Pecoraro 		mattbaker: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1 2017-09-26 23:06:20 PDT
Created attachment 321938 [details] [PATCH] Proposed Fix
Build Bot
Comment 2 2017-09-26 23:08:18 PDT
Attachment 321938 [details] did not pass style-queue: ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Matt Baker
Comment 3 2017-09-27 08:36:35 PDT
Comment on attachment 321938 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=321938&action=review r=me > Source/WebCore/ChangeLog:8 > + No new tests (OOPS!). Remove this.
Joseph Pecoraro
Comment 4 2017-09-27 10:57:49 PDT
<https://trac.webkit.org/changeset/222560/webkit>
Radar WebKit Bug Importer
Comment 5 2017-09-27 12:14:50 PDT
<rdar://problem/34692859>
Note You need to log in before you can comment on or make changes to this bug.